Support DevTools in Chromium version of Edge

quehanwei · Sep 14, 2020 · 252d731 · 252d731
1 parent 9a3bede
commit 252d731
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/rb/lib/selenium/webdriver/chrome/driver.rb b/rb/lib/selenium/webdriver/chrome/driver.rb
@@ -45,6 +45,12 @@ def bridge_class
         def execute_cdp(cmd, **params)
           @bridge.send_command(cmd: cmd, params: params)
         end
+
+        private
+
+        def debugger_address
+          capabilities['goog:chromeOptions']['debuggerAddress']
+        end
       end # Driver
     end # Chrome
   end # WebDriver

diff --git a/rb/lib/selenium/webdriver/common/driver_extensions/has_devtools.rb b/rb/lib/selenium/webdriver/common/driver_extensions/has_devtools.rb
@@ -30,7 +30,7 @@ module HasDevTools
 
         def devtools
           version = Integer(capabilities.browser_version.split('.').first)
-          @devtools ||= DevTools.new(url: capabilities['goog:chromeOptions']['debuggerAddress'], version: version)
+          @devtools ||= DevTools.new(url: debugger_address, version: version)
         end
 
       end # HasDevTools

diff --git a/rb/lib/selenium/webdriver/edge_chrome/driver.rb b/rb/lib/selenium/webdriver/edge_chrome/driver.rb
@@ -36,6 +36,12 @@ def browser
         def bridge_class
           Bridge
         end
+
+        private
+
+        def debugger_address
+          capabilities['ms:edgeOptions']['debuggerAddress']
+        end
       end # Driver
     end # EdgeChrome
   end # WebDriver

diff --git a/rb/spec/integration/selenium/webdriver/devtools_spec.rb b/rb/spec/integration/selenium/webdriver/devtools_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe DevTools, only: {driver: :chrome} do
+    describe DevTools, only: {driver: %i[chrome edge]} do
       after do
         quit_driver
       end