[java] Using try-with-resources to automatically close prepared state…

…ments
quehanwei · Jun 16, 2020 · 2a5c4e7 · 2a5c4e7
1 parent d7a3443
commit 2a5c4e7
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/java/server/src/org/openqa/selenium/grid/sessionmap/jdbc/JdbcBackedSessionMap.java b/java/server/src/org/openqa/selenium/grid/sessionmap/jdbc/JdbcBackedSessionMap.java
@@ -89,9 +89,8 @@ public static SessionMap create(Config config) {
   public boolean add(Session session) {
     Require.nonNull("Session to add", session);
 
-    try {
-      return insertSessionStatement(session).executeUpdate() >= 1;
-
+    try (PreparedStatement statement = insertSessionStatement(session)) {
+      return statement.executeUpdate() >= 1;
     } catch (SQLException e) {
       throw new JdbcException(e);
     }
@@ -105,7 +104,7 @@ public Session get(SessionId id) throws NoSuchSessionException {
     Capabilities caps = null;
     String rawUri = null;
 
-    try (ResultSet sessions = readSessionStatement(id).executeQuery()){
+    try (PreparedStatement statement = readSessionStatement(id); ResultSet sessions = statement.executeQuery()) {
       if (!sessions.next()) {
         throw new NoSuchSessionException("Unable to find...");
       }