Skip to content

Commit

Permalink
Remove python top level class method which is never included or extended
Browse files Browse the repository at this point in the history
Alter rakefile order, remove uncalled requires and add comments about each section of requires
  • Loading branch information
luke-hill authored and barancev committed Oct 30, 2019
1 parent 341dc6e commit a2e6d4b
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 64 deletions.
5 changes: 2 additions & 3 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ require 'rake_tasks/crazy_fun/main'
require 'rake_tasks/selenium_rake/detonating_handler'
require 'rake_tasks/selenium_rake/crazy_fun'

# The CrazyFun builders - Most of these are either partially or fully obsolete
require 'rake_tasks/crazy_fun/mappings/tasks'
require 'rake_tasks/crazy_fun/mappings/javascript'
require 'rake_tasks/crazy_fun/mappings/rake'
require 'rake_tasks/crazy_fun/mappings/rename'
require 'rake_tasks/crazy_fun/mappings/ruby'

# Location of all new methods
Expand All @@ -36,8 +36,7 @@ require 'rake_tasks/selenium_rake/type_definitions_generator'
require 'rake_tasks/rake/task'
require 'rake_tasks/rake/dsl'

# Require the migrated rake files, which need to be tidied up further
# These are the final items mixed into the global NS
# These are the final items mixed into the global NS, should be namespaced correctly
require 'rake_tasks/bazel'
require 'rake_tasks/copyright'
require 'rake_tasks/python'
Expand Down
6 changes: 0 additions & 6 deletions rake_tasks/crazy_fun/mappings/python.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1 @@
require 'rake_tasks/selenium_rake/checks'

module Python
def self.lib_dir
Dir.glob('build/lib*')[0] || 'build/lib'
end
end
12 changes: 0 additions & 12 deletions rake_tasks/crazy_fun/mappings/rename/add_dependencies.rb

This file was deleted.

9 changes: 0 additions & 9 deletions rake_tasks/crazy_fun/mappings/rename/check_preconditions.rb

This file was deleted.

21 changes: 0 additions & 21 deletions rake_tasks/crazy_fun/mappings/rename/export.rb

This file was deleted.

13 changes: 0 additions & 13 deletions rake_tasks/crazy_fun/mappings/rename_mappings.rb

This file was deleted.

0 comments on commit a2e6d4b

Please sign in to comment.