[py] Extending proxy ignoring to direct clients instead of just remote

quehanwei · Oct 14, 2020 · c785b1f · c785b1f
1 parent 3daf112
commit c785b1f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/py/selenium/webdriver/chromium/remote_connection.py b/py/selenium/webdriver/chromium/remote_connection.py
@@ -19,8 +19,8 @@
 
 
 class ChromiumRemoteConnection(RemoteConnection):
-    def __init__(self, remote_server_addr, vendor_prefix, browser_name, keep_alive=True):
-        RemoteConnection.__init__(self, remote_server_addr, keep_alive)
+    def __init__(self, remote_server_addr, vendor_prefix, browser_name, keep_alive=True, ignore_proxy=False):
+        RemoteConnection.__init__(self, remote_server_addr, keep_alive, ignore_proxy=ignore_proxy)
         self.browser_name = browser_name
         self._commands["launchApp"] = ('POST', '/session/$sessionId/chromium/launch_app')
         self._commands["setNetworkConditions"] = ('POST', '/session/$sessionId/chromium/network_conditions')

diff --git a/py/selenium/webdriver/firefox/remote_connection.py b/py/selenium/webdriver/firefox/remote_connection.py
@@ -23,8 +23,8 @@ class FirefoxRemoteConnection(RemoteConnection):
 
     browser_name = DesiredCapabilities.FIREFOX['browserName']
 
-    def __init__(self, remote_server_addr, keep_alive=True):
-        RemoteConnection.__init__(self, remote_server_addr, keep_alive)
+    def __init__(self, remote_server_addr, keep_alive=True, ignore_proxy=False):
+        RemoteConnection.__init__(self, remote_server_addr, keep_alive, ignore_proxy=ignore_proxy)
 
         self._commands["GET_CONTEXT"] = ('GET', '/session/$sessionId/moz/context')
         self._commands["SET_CONTEXT"] = ("POST", "/session/$sessionId/moz/context")

diff --git a/py/selenium/webdriver/remote/webdriver.py b/py/selenium/webdriver/remote/webdriver.py
@@ -127,7 +127,7 @@ def get_remote_connection(capabilities, command_executor, keep_alive, ignore_loc
         RemoteConnection
     )
 
-    return handler(command_executor, keep_alive=keep_alive)
+    return handler(command_executor, keep_alive=keep_alive, ignore_proxy=ignore_local_proxy)
 
 
 @add_metaclass(ABCMeta)

diff --git a/py/selenium/webdriver/safari/remote_connection.py b/py/selenium/webdriver/safari/remote_connection.py
@@ -23,8 +23,8 @@ class SafariRemoteConnection(RemoteConnection):
 
     browser_name = DesiredCapabilities.SAFARI['browserName']
 
-    def __init__(self, remote_server_addr, keep_alive=True):
-        RemoteConnection.__init__(self, remote_server_addr, keep_alive)
+    def __init__(self, remote_server_addr, keep_alive=True, ignore_proxy=False):
+        RemoteConnection.__init__(self, remote_server_addr, keep_alive, ignore_proxy=ignore_proxy)
 
         self._commands["GET_PERMISSIONS"] = ('GET', '/session/$sessionId/apple/permissions')
         self._commands["SET_PERMISSIONS"] = ('POST', '/session/$sessionId/apple/permissions')