[java] Reworking ImmutableCapabilities to make them actually immutable

quehanwei · May 25, 2020 · e6f3142 · e6f3142
1 parent 6d026c5
commit e6f3142
Showing 1 changed file with 50 additions and 17 deletions.
diff --git a/java/client/src/org/openqa/selenium/ImmutableCapabilities.java b/java/client/src/org/openqa/selenium/ImmutableCapabilities.java
@@ -22,37 +22,39 @@
 import java.io.Serializable;
 import java.util.Map;
 
-public class ImmutableCapabilities extends AbstractCapabilities implements Serializable {
+public class ImmutableCapabilities implements Capabilities, Serializable {
 
   private static final long serialVersionUID = 665766108972704060L;
 
+  private MutableCapabilities delegate = new MutableCapabilities();
+
   public ImmutableCapabilities() {
   }
 
   public ImmutableCapabilities(String k, Object v) {
-    setCapability(k, v);
+    delegate.setCapability(k, v);
   }
 
   public ImmutableCapabilities(String k1, Object v1, String k2, Object v2) {
-    setCapability(k1, v1);
-    setCapability(k2, v2);
+    delegate.setCapability(k1, v1);
+    delegate.setCapability(k2, v2);
   }
 
   public ImmutableCapabilities(String k1, Object v1, String k2, Object v2, String k3, Object v3) {
-    setCapability(k1, v1);
-    setCapability(k2, v2);
-    setCapability(k3, v3);
+    delegate.setCapability(k1, v1);
+    delegate.setCapability(k2, v2);
+    delegate.setCapability(k3, v3);
   }
 
   public ImmutableCapabilities(
       String k1, Object v1,
       String k2, Object v2,
       String k3, Object v3,
       String k4, Object v4) {
-    setCapability(k1, v1);
-    setCapability(k2, v2);
-    setCapability(k3, v3);
-    setCapability(k4, v4);
+    delegate.setCapability(k1, v1);
+    delegate.setCapability(k2, v2);
+    delegate.setCapability(k3, v3);
+    delegate.setCapability(k4, v4);
   }
 
   public ImmutableCapabilities(
@@ -61,11 +63,11 @@ public ImmutableCapabilities(
       String k3, Object v3,
       String k4, Object v4,
       String k5, Object v5) {
-    setCapability(k1, v1);
-    setCapability(k2, v2);
-    setCapability(k3, v3);
-    setCapability(k4, v4);
-    setCapability(k5, v5);
+    delegate.setCapability(k1, v1);
+    delegate.setCapability(k2, v2);
+    delegate.setCapability(k3, v3);
+    delegate.setCapability(k4, v4);
+    delegate.setCapability(k5, v5);
   }
 
   public ImmutableCapabilities(Capabilities other) {
@@ -75,10 +77,41 @@ public ImmutableCapabilities(Capabilities other) {
   public ImmutableCapabilities(Map<?, ?> capabilities) {
     capabilities.forEach((key, value) -> {
       Require.argument("Key", key).instanceOf(String.class);
-      setCapability(String.valueOf(key), value);
+      delegate.setCapability(String.valueOf(key), value);
     });
   }
 
+  @Override
+  public Object getCapability(String capabilityName) {
+    return delegate.getCapability(capabilityName);
+  }
+
+  @Override
+  public Map<String, Object> asMap() {
+    return delegate.asMap();
+  }
+
+  @Override
+  public int hashCode() {
+    return delegate.hashCode();
+  }
+
+  @Override
+  public boolean equals(Object o) {
+    if (this == o) {
+      return true;
+    }
+    if (!(o instanceof Capabilities)) {
+      return false;
+    }
+    return delegate.equals(o);
+  }
+
+  @Override
+  public String toString() {
+    return delegate.toString();
+  }
+
   public static ImmutableCapabilities copyOf(Capabilities capabilities) {
     Require.nonNull("Capabilities", capabilities);