Skip to content

Commit

Permalink
Build: Fix TestSwarm config after renaming test suite
Browse files Browse the repository at this point in the history
  • Loading branch information
@JamesMGreene
JamesMGreene committed Sep 11, 2014
1 parent 3f08a1a commit 150ecaf
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions Gruntfile.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,10 @@ grunt.registerTask( "testswarm", function( commit, configFile, projectName, brow
}
timeout = timeout || 1000 * 60 * 15;

[ "index", "async", "setTimeout" ].forEach(function( suite ) {
runs[ suite ] = config.testUrl + commit + "/test/" + suite + ".html";
});
[ "index", "autostart", "startError", "setTimeout" ]
.forEach(function( suite ) {
runs[ suite ] = config.testUrl + commit + "/test/" + suite + ".html";
});

testswarm
.createClient({
Expand Down

6 comments on commit 150ecaf

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this not include logs?

@JamesMGreene
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, then took it back out as, for some reason or another, logs times out across the board on every browser when run via TestSwarm. I assume this was why it wasn't included in the list previously as well.

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. I have a similar problem with browserstack-runner, though only IE6/7 register the done callback after the testsuite finished. I'm going to kick it out of browserstack.json for now as well.

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually its autostart.html that times out with browserstack-runner. logs works fine, I think...

@JamesMGreene
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browserstack-runner really needs to color the timeout lines in red text. I struggled to find them amongst the console output.

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's next in line, there's still too much useless noise for passing tests.

Please sign in to comment.