Skip to content

Commit

Permalink
When killing buck, escape the path to the pex
Browse files Browse the repository at this point in the history
This is because we might well have spaces in the path
name. And, as we all know, spaces are the work of things
that are very, very evil when using build tools.

Fixed in the Fix a Committer, Become a Bug session at
Selenium Conf '16.

/face palm, one more time. Oh yeah!
  • Loading branch information
shs96c committed Jun 26, 2016
1 parent 5b7e46c commit b83fdca
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rake-tasks/buck.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def self.download

if cached_hash == out_hash
# Make sure we're running a pristine buck instance
sh "python #{out} kill"
sh "python \"#{out}\" kill"
return ["python", out]
end

Expand All @@ -38,7 +38,7 @@ def self.download

ant.get('src' => url, 'dest' => out, 'verbose' => true)
File.chmod(0755, out)
sh "python #{out} kill"
sh "python \"#{out}\" kill"
["python", out]
)
end
Expand Down

0 comments on commit b83fdca

Please sign in to comment.