Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Support deb-get #925

Merged
merged 4 commits into from
May 7, 2022
Merged

Support deb-get #925

merged 4 commits into from
May 7, 2022

Conversation

r-darwish
Copy link
Owner

Fixes #923

Standards checklist:

  • The PR title is descriptive.
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself
    • I also tested that Topgrade skips the step where needed

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@r-darwish
Copy link
Owner Author

@Zahrun please test this change

@Zahrun
Copy link
Contributor

Zahrun commented May 7, 2022

Thank you for the quick addition.
It seems the "update" step is not required since the only difference is that it will do "apt-get update", and we already do this in a previous topgrade step . So "upgrade" alone will work for deb-get.
Also we are missing this header:
―― 10:40:35 - deb-get ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

EDIT: you corrected the title before I posted. Let me test it.

@Zahrun
Copy link
Contributor

Zahrun commented May 7, 2022

The separator displays correctly.
We can remove the ctx.execute_elevated(&deb_get, false)?.arg("update").check_run()?; line and we are good.

@r-darwish r-darwish enabled auto-merge (squash) May 7, 2022 06:12
@r-darwish r-darwish merged commit fdf03f6 into master May 7, 2022
@r-darwish r-darwish deleted the r-darwish/issue923 branch May 7, 2022 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support deb-get
2 participants