Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Trim go paths #940

Merged
merged 2 commits into from
May 24, 2022
Merged

Trim go paths #940

merged 2 commits into from
May 24, 2022

Conversation

r-darwish
Copy link
Owner

No description provided.

@r-darwish
Copy link
Owner Author

@jtsagata can you please check this branch?

@MCOfficer
Copy link
Contributor

MCOfficer commented May 23, 2022

Files and directories can technically end in whitespace, so there's the extremely unlikely scenario that this will break go updates for users who have their gopath set to, say ~/mygo

Edit: Seems like github strips whitespace as well. Oh well

@jtsagata
Copy link

It's working as expected with the trimming.

Now, if my $GOPATH, or any directory, ends with space, I will expect much more Sirius problems than this :-). Maybe just remove a trailing `\n;

@r-darwish r-darwish enabled auto-merge (squash) May 24, 2022 06:23
@r-darwish r-darwish merged commit c916168 into master May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants