-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integration openzeppelin evm template #284
Open
AlexD10S
wants to merge
14
commits into
main
Choose a base branch
from
oz-evm-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 70.32% 70.54% +0.21%
==========================================
Files 53 53
Lines 9098 9196 +98
Branches 9098 9196 +98
==========================================
+ Hits 6398 6487 +89
- Misses 1718 1719 +1
- Partials 982 990 +8
|
Thanks for that! Looking great to me as well |
pepoviola
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick review, a few minor comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to support OZ EVM template: https://github.com/OpenZeppelin/polkadot-runtime-templates/tree/main/evm-template
To support EVM chains in Zombienet, the config file includes
force_decorator = "generic-evm"
. When this field is present,pop
injectsevm_based = true
to ensure compatibility with Zombienet-SDK after the recent fix: paritytech/zombienet-sdk#256