Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add community section to README #289

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

brunopgalvao
Copy link
Collaborator

ditto

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.22%. Comparing base (43e4cd0) to head (094dae3).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   70.22%   70.22%           
=======================================
  Files          51       51           
  Lines        8673     8673           
  Branches     8673     8673           
=======================================
  Hits         6091     6091           
  Misses       1630     1630           
  Partials      952      952           

Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
But I think is a better idea to add the Telegram and all the links as we have it in the pop network repository: https://github.com/r0gue-io/pop-node

@brunopgalvao
Copy link
Collaborator Author

Nice. But I think is a better idea to add the Telegram and all the links as we have it in the pop network repository: https://github.com/r0gue-io/pop-node

Yes we should add it there as well. Inspiration came from Scio Labs ink!athon repo:

@AlexD10S
Copy link
Collaborator

Nice. But I think is a better idea to add the Telegram and all the links as we have it in the pop network repository: https://github.com/r0gue-io/pop-node

Yes we should add it there as well. Inspiration came from Scio Labs ink!athon repo:

The Telegram link is in the pop-node README. My proposal is to add it here as well, using the same format and including it with the badges there.

Use same format as pop-node repo for Telegram link
@AlexD10S AlexD10S self-requested a review August 26, 2024 08:02
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@brunopgalvao brunopgalvao merged commit 11ea129 into main Aug 26, 2024
17 of 18 checks passed
@brunopgalvao brunopgalvao deleted the bruno/add-community branch August 26, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants