test: use module CLI in all commands and add unit test in pop-cli crate #315
clippy
100 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 100 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.81.0 (eeb90cda1 2024-09-04)
- cargo 1.81.0 (2dbb1af80 2024-08-20)
- clippy 0.1.81 (eeb90cd 2024-09-04)
Annotations
Check warning on line 13 in crates/pop-cli/src/commands/new/mod.rs
github-actions / clippy
missing documentation for a macro
warning: missing documentation for a macro
--> crates/pop-cli/src/commands/new/mod.rs:13:1
|
13 | macro_rules! enum_variants {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 56 in crates/pop-cli/src/main.rs
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> crates/pop-cli/src/main.rs:56:1
|
56 | pub struct Cli {
| ^^^^^^^^^^^^^^
Check warning on line 132 in crates/pop-cli/src/main.rs
github-actions / clippy
missing documentation for the crate
warning: missing documentation for the crate
--> crates/pop-cli/src/main.rs:3:1
|
3 | / #[cfg(not(any(feature = "contract", feature = "parachain")))]
4 | | compile_error!("feature \"contract\" or feature \"parachain\" must be enabled");
5 | |
6 | | use anyhow::{anyhow, Result};
... |
131 | | }
132 | | }
| |_^
|
= note: requested on the command line with `-W missing-docs`
Check warning on line 219 in crates/pop-cli/src/commands/up/parachain.rs
github-actions / clippy
using `map` over `inspect`
warning: using `map` over `inspect`
--> crates/pop-cli/src/commands/up/parachain.rs:219:5
|
219 | .map(|b| {
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
219 ~ .inspect(|b| {
220 | if latest && b.stale() {
221 | b.use_latest()
222 ~ }
|
Check warning on line 53 in crates/pop-cli/src/cli.rs
github-actions / clippy
methods `required` and `validate` are never used
warning: methods `required` and `validate` are never used
--> crates/pop-cli/src/cli.rs:53:6
|
45 | pub trait Input {
| ----- methods in this trait
...
53 | fn required(self, required: bool) -> Self;
| ^^^^^^^^
54 | /// Sets a validation callback for the input that is called when the user submits.
55 | fn validate(
| ^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 216 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:216:2
|
216 | pub fn license(&self) -> Option<&str> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 212 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:212:2
|
212 | pub fn is_audited(&self) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 206 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:206:2
|
206 | pub fn is_supported_version(&self, version: &str) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 202 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:202:2
|
202 | pub fn supported_versions(&self) -> Option<Vec<&str>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 138 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:138:2
|
138 | OpenZeppelinGeneric,
| ^^^^^^^^^^^^^^^^^^^
Check warning on line 51 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> crates/pop-parachains/src/templates.rs:51:2
|
51 | pub initial_endowment: String,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 50 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> crates/pop-parachains/src/templates.rs:50:2
|
50 | pub decimals: u8,
| ^^^^^^^^^^^^^^^^
Check warning on line 49 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a struct field
warning: missing documentation for a struct field
--> crates/pop-parachains/src/templates.rs:49:2
|
49 | pub symbol: String,
| ^^^^^^^^^^^^^^^^^^
Check warning on line 33 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:33:2
|
33 | Parity,
| ^^^^^^
Check warning on line 26 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:26:2
|
26 | OpenZeppelin,
| ^^^^^^^^^^^^
Check warning on line 19 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:19:2
|
19 | Pop,
| ^^^
Check warning on line 86 in crates/pop-parachains/src/new_pallet/new_pallet_options.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/new_pallet/new_pallet_options.rs:86:2
|
86 | CustomOrigin,
| ^^^^^^^^^^^^
Check warning on line 84 in crates/pop-parachains/src/new_pallet/new_pallet_options.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/new_pallet/new_pallet_options.rs:84:2
|
84 | GenesisConfig,
| ^^^^^^^^^^^^^
Check warning on line 45 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:45:2
|
45 | WorkspaceLocate,
| ^^^^^^^^^^^^^^^
Check warning on line 43 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:43:2
|
43 | UnsupportedCommand(String),
| ^^^^^^^^^^^^^^^^^^
Check warning on line 41 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:41:2
|
41 | TomlError(#[from] toml_edit::de::Error),
| ^^^^^^^^^
Check warning on line 39 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:39:2
|
39 | SourcingError(#[from] pop_common::sourcing::Error),
| ^^^^^^^^^^^^^
Check warning on line 37 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:37:2
|
37 | RustfmtError(std::io::Error),
| ^^^^^^^^^^^^
Check warning on line 35 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:35:2
|
35 | PathError,
| ^^^^^^^^^
Check warning on line 33 in crates/pop-parachains/src/errors.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/errors.rs:33:2
|
33 | PalletDirCreation,
| ^^^^^^^^^^^^^^^^^