Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: pop api #190

Merged
merged 6 commits into from
Aug 16, 2024
Merged

docs: pop api #190

merged 6 commits into from
Aug 16, 2024

Conversation

Daanvdplas
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.62%. Comparing base (8b4f595) to head (dfb7e3e).
Report is 1 commits behind head on daan/api.

@@            Coverage Diff            @@
##           daan/api     #190   +/-   ##
=========================================
  Coverage     33.62%   33.62%           
=========================================
  Files            34       34           
  Lines          2995     2995           
  Branches       2995     2995           
=========================================
  Hits           1007     1007           
  Misses         1956     1956           
  Partials         32       32

evilrobot-01
evilrobot-01 requested changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some obvious errors which need fixing. Have provided various suggestions to speed up the process.

pop-api/src/lib.rs Outdated Show resolved Hide resolved
pop-api/src/lib.rs Outdated Show resolved Hide resolved
pop-api/src/v0/assets/fungibles.rs Outdated Show resolved Hide resolved
pop-api/src/v0/assets/fungibles.rs Outdated Show resolved Hide resolved
pop-api/src/v0/assets/fungibles.rs Outdated Show resolved Hide resolved
pop-api/src/v0/assets/fungibles.rs Outdated Show resolved Hide resolved
pop-api/src/v0/assets/fungibles.rs Outdated Show resolved Hide resolved
pop-api/src/v0/assets/fungibles.rs Outdated Show resolved Hide resolved
pop-api/src/v0/mod.rs Outdated Show resolved Hide resolved
pop-api/src/v0/assets/mod.rs Outdated Show resolved Hide resolved
@Daanvdplas Daanvdplas mentioned this pull request Aug 15, 2024
Merged
19 tasks
@Daanvdplas
Copy link
Collaborator Author

Thanks for the review! All comments resolved

evilrobot-01
evilrobot-01 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjust to asset_management module suggested, not a blocker from merging tho.

pop-api/src/v0/assets/fungibles.rs Outdated Show resolved Hide resolved
@Daanvdplas @evilrobot-01
Update pop-api/src/v0/assets/fungibles.rs
dfb7e3e 
Co-authored-by: Frank Bell <60948618+evilrobot-01@users.noreply.github.com>
@Daanvdplas Daanvdplas merged commit f13b39c into daan/api Aug 16, 2024
8 checks passed
@Daanvdplas Daanvdplas deleted the daan/docs-pop_api branch August 16, 2024 08:27
chungquantin pushed a commit that referenced this pull request Sep 6, 2024
@Daanvdplas @evilrobot-01 @chungquantin
docs: pop api (#190)
d471a14 
Co-authored-by: Frank Bell <60948618+evilrobot-01@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilrobot-01 evilrobot-01 evilrobot-01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daanvdplas @codecov-commenter @evilrobot-01