Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devnet): runtime non-fungibles extensions #266

Open
wants to merge 2 commits into
base: chungquatin/runtime-non_fungibles
Choose a base branch
from

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Sep 6, 2024

Implement runtime pallet functionality extensions of the non-fungibles use case

Important

Questionable approach in the set_attribute method and ItemAttribute state query: How can we handle the namespace? Should we dynamically identify the namespace based on the provided origin address? For ItemAttribute, should we simplify it by returning all attributes of the collection item or only one single key-value per call.

@chungquantin chungquantin changed the title runtime: non fungibles extensions feat: runtime non-fungibles extensions Sep 6, 2024
@chungquantin chungquantin changed the title feat: runtime non-fungibles extensions feat(devnet): runtime non-fungibles extensions Sep 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.80645% with 23 lines in your changes missing coverage. Please review.

Project coverage is 38.78%. Comparing base (c1132c5) to head (72d7f8f).

Files with missing lines Patch % Lines
pallets/api/src/non_fungibles/mod.rs 25.80% 23 Missing ⚠️
@@                          Coverage Diff                          @@
##           chungquatin/runtime-non_fungibles     #266      +/-   ##
=====================================================================
- Coverage                              38.93%   38.78%   -0.15%     
=====================================================================
  Files                                     37       37              
  Lines                                   3277     3305      +28     
  Branches                                3277     3305      +28     
=====================================================================
+ Hits                                    1276     1282       +6     
- Misses                                  1973     1995      +22     
  Partials                                  28       28              
Files with missing lines Coverage Δ
pallets/api/src/non_fungibles/mod.rs 54.36% <25.80%> (-12.30%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants