feat: psp22 trait contract example with drink tests #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# This is the 1st commit message: refactor: general # This is the commit message #2: init # This is the commit message #3: begin refactor # This is the commit message #4: refactor: error handling # This is the commit message #5: tests: add error handling tests # This is the commit message #6: WIP # This is the commit message #7: finalise error handling # This is the commit message #8: refactor: easier review
Co-authored-by: Frank Bell <frank@r0gue.io>
chungquantin
commented
Sep 26, 2024
Daanvdplas
requested changes
Sep 26, 2024
Daanvdplas
reviewed
Sep 26, 2024
evilrobot-01
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Example largely looks great, a few improvements can be made imo. Whilst it is awesome that the drink tests are working, I feel that the implementation of the tests is too complex and can be made much more digestible with some refactoring.
Some stuff can be moved to pop-drink, some stuff to eliminate the some initialisation in each test etc. We want to eliminate as much boilerplate as possible, so the example tests showcase how easy it is to write tests using the API. As it stands, there is considerable effort required for the developer.
Co-authored-by: Daanvdplas <daanvdplas@live.nl>
Co-authored-by: Daanvdplas <daanvdplas@live.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example contract for the fungible use case that applies the PSP22 traits from #297. The PR includes:
pop-drinkandpop-sandbox, implemented in chore(devnet): add sandbox & test contracts with drink #277