Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capitalize the first character of component name #272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SyMind
Copy link

@SyMind SyMind commented Sep 5, 2022

@fahhadalsubaie
Copy link

Thank you for saving my time!

@@ -22,7 +22,7 @@
"",
"type State = {}",
"",
"export default class ${1:${TM_FILENAME_BASE}} extends Component<Props, State> {",
"export default class ${1:${TM_FILENAME_BASE/(.*)/${1:/capitalize}/}} extends Component<Props, State> {",
Copy link

@Yaronglp Yaronglp Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made a great change, but what would happen if I want to push another snippet? or if I will have another request for changes on the component's name?
I think we can optimize it.
I'm suggesting formatting the component name only in one place and reusing that place.
i.e, use the TM_FILENAME_BASE and capitalize it before using it on the generated.json.
Then you will do all your changes in one place and only once, instead of repeating the logic for every snippet.
what do you say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants