wrap image write in try #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r9y9
requested changes
Nov 19, 2019
tripzero
force-pushed
the
try_image_write
branch
from
d199b73
to
2737517
Compare
|
Are CI failures related to the pytorch version? What can we do to get deepvoice working on the latest? |
1 similar comment
|
Are CI failures related to the pytorch version? What can we do to get deepvoice working on the latest? |
r9y9
reviewed
Dec 19, 2019
train.py
Outdated
| mel_output = prepare_spec_image(audio._denormalize(mel_output)) | ||
| writer.add_image("Predicted mel spectrogram", mel_output, global_step) | ||
| try: | ||
| mel_output = mel_outputs[idx].cpu().data.numpy() |
There was a problem hiding this comment.
Could you move this line to the out of try block? Seems irrelevant.
train.py
Outdated
Comment on lines
465
to
470
| # Save averaged alignment | ||
| alignment_dir = join(checkpoint_dir, "alignment_ave") | ||
| os.makedirs(alignment_dir, exist_ok=True) | ||
| path = join(alignment_dir, "step{:09d}_layer_{}_alignment.png".format( | ||
| global_step, i + 1)) | ||
| path = join(alignment_dir, | ||
| "step{:09d}_alignment.png".format(global_step)) | ||
| alignment = attn.mean(0)[idx].cpu().data.numpy() |
There was a problem hiding this comment.
Please move the code to out of try block.
This sometimes fails due to "Unsupported format" error. Report the exception and move on.
tripzero
force-pushed
the
try_image_write
branch
from
2737517
to
68296f7
Compare
r9y9
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sometimes fails due to "Unsupported format" error.
Report the exception and move on.