Skip to content

Commit

Permalink
Don't swallow exceptions unless abort is specified.
Browse files Browse the repository at this point in the history
  • Loading branch information
lukebakken committed Jan 26, 2024
1 parent 19cc98b commit 5421696
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions projects/RabbitMQ.Client/client/impl/Connection.cs
Original file line number Diff line number Diff line change
Expand Up @@ -374,17 +374,7 @@ await _session0.TransmitAsync(method, cancellationToken)
await _mainLoopTask.WaitAsync(timeout, cancellationToken)
.ConfigureAwait(false);
}
catch (AggregateException)
{
}
// TODO timeout vs real cancellation?
catch (OperationCanceledException)
{
}
catch (TimeoutException)
{
}
finally
catch
{
try
{
Expand All @@ -395,6 +385,11 @@ await _frameHandler.CloseAsync()
catch
{
}

if (false == abort)
{
throw;
}
}
}

Expand Down

0 comments on commit 5421696

Please sign in to comment.