Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

µRefactor PartialEq for WidgetCore #84

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

snpefk
Copy link
Contributor

@snpefk snpefk commented Mar 12, 2020

tremendously improve performance :)

@rabite0
Copy link
Owner

rabite0 commented May 21, 2020

Where does this improve performance? A short test shows no difference while browsing through a directory. Looks much nicer, so merged anyway.

@rabite0 rabite0 merged commit f434936 into rabite0:master May 21, 2020
@snpefk snpefk deleted the patch-1 branch May 21, 2020 19:00
@snpefk
Copy link
Contributor Author

snpefk commented May 21, 2020

Where does this improve performance?

It was just a silly joke

@rabite0
Copy link
Owner

rabite0 commented May 22, 2020

Oh, I see, so you just wanted in on that list of contributors ;).
If you're interested, I think I saw at least one other PartialEq implementation yesterday that looked just like that. Well, I guess there are a lot of places that could use clean ups like that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants