Skip to content

Commit

Permalink
Minor cleanup, fixes PHPMailer#918, broken version file
Browse files Browse the repository at this point in the history
Remove duplicate check for Sender address
  • Loading branch information
Synchro committed Dec 26, 2016
1 parent ed4e7ce commit 9e4b8fb
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5.2.16
5.2.19
3 changes: 3 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# ChangeLog

## Version 5.2.19 (December 26th 2016)
* Minor cleanup

## Version 5.2.18 (December 24th 2016)
* **SECURITY** Critical security update for CVE-2016-10033 please update now! Thanks to [Dawid Golunski](https://legalhackers.com).
* Add ability to extract the SMTP transaction ID from some common SMTP success messages
Expand Down
5 changes: 2 additions & 3 deletions class.phpmailer.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class PHPMailer
* The PHPMailer Version number.
* @var string
*/
public $Version = '5.2.18';
public $Version = '5.2.19';

/**
* Email priority.
Expand Down Expand Up @@ -164,7 +164,6 @@ class PHPMailer

/**
* The path to the sendmail program.
* Must contain only a path to an executable, with no parameters or switches
* @var string
*/
public $Sendmail = '/usr/sbin/sendmail';
Expand Down Expand Up @@ -1365,7 +1364,7 @@ public function postSend()
*/
protected function sendmailSend($header, $body)
{
if (!empty($this->Sender) and $this->validateAddress($this->Sender)) {
if (!empty($this->Sender)) {
if ($this->Mailer == 'qmail') {
$sendmail = sprintf('%s -f%s', escapeshellcmd($this->Sendmail), escapeshellarg($this->Sender));
} else {
Expand Down
2 changes: 1 addition & 1 deletion class.pop3.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class POP3
* @var string
* @access public
*/
public $Version = '5.2.18';
public $Version = '5.2.19';

/**
* Default POP3 port number.
Expand Down
4 changes: 2 additions & 2 deletions class.smtp.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class SMTP
* The PHPMailer SMTP version number.
* @var string
*/
const VERSION = '5.2.18';
const VERSION = '5.2.19';

/**
* SMTP line break constant.
Expand Down Expand Up @@ -81,7 +81,7 @@ class SMTP
* @deprecated Use the `VERSION` constant instead
* @see SMTP::VERSION
*/
public $Version = '5.2.18';
public $Version = '5.2.19';

/**
* SMTP server port number.
Expand Down

0 comments on commit 9e4b8fb

Please sign in to comment.