Add font-lock for el-patch-def* forms #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raxod502
reviewed
Jan 20, 2021
There was a problem hiding this comment.
This looks great, just two last things:
- The docstring for
el-patch-deftypeshould mentionFONT-LOCK, like the other argments. - This section of the README should be updated because it has a code snippet showing the definition of
el-patch-defun, so that snippet should add the new keyword argument along with the source code.
haji-ali
reviewed
Mar 1, 2021
| (font-lock-add-keywords | ||
| 'emacs-lisp-mode | ||
| `((,(concat | ||
| (format "(\\(el-patch-%S\\)\\>[[:blank:]]+\\(" type) |
There was a problem hiding this comment.
Shouldn't this account for macroname in case it is not nil in el-patch-deftype?
There was a problem hiding this comment.
Oh yeah, that's right. I... am not sure why I implemented this macro-name feature in the first place, but yes, it should be supported here as long as we've got it.
|
This thread is being closed automatically by Tidier because it is labeled with "waiting on response" and has not seen any activity for 90 days. But don't worry—if you have any information that might advance the discussion, leave a comment and I will be happy to reopen the thread :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #38