-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Byte and native compilations issues #516
Comments
That's odd. Byte-compilation has a lot of weird issues and it might be a good idea to do some significant restructuring to make problems like this cause fewer issues. In your checkout, I don't suppose there is something relevant at Line 2413 in b227bcd
I am also afraid to say I do not know what could be causing the native compilation error. I am very open to fixes. |
Ah sorry, I added some comments before which shifted the line-numbers, for me the line is Lines 2345 to 2346 in b227bcd
Perhaps the reason is that
Am I alone in this issue or is it working in your setup somehow? I think that the current structure is not amenable to native-compilation since the definitions are in a different file while This is not a super important feature to have for me (even with just byte-compilation my radian start-time is just 0.3 sec while my additional config of 7K lines is 0.16 sec). But if I am correct, it would be good to keep in mind for any future restructuring. |
I personally have used native compilation with Emacs 28 and Radian and no error before. However, I've had weird issues in the past around compilation.
|
Ok, looking at this more seriously, I can definitely reproduce the error simply by disabling |
Fixed the |
Take a look at your native compilation error and see if it goes away also with the recent commit. |
Yep, byte-compiling works now. Thanks! Native compilation is a separate issue for me (it fails at the outset in the I will close the issue for now and reopen it when I have more information |
Just realized that radian.el has |
I finally manged to compile radian with my config. But now I am getting the warning (I am using Emacs 28.1):
Even though it's defined here
radian/emacs/radian.el
Lines 2332 to 2336 in b227bcd
If I move the definition to outside the
radian-use-package
, everything works as expected. I believe the reason is because I havelsp-mode
inradian-disabled-packages
.Another issue I am seeing is this error in
*Aync-native-compile-log*
when native-compiling:The text was updated successfully, but these errors were encountered: