-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please use the default value for outline-regexp #437
Comments
As a side-note: ...
;;;; Closing remarks
(provide 'prescient)
;;; prescient.el ends here
;; Local Variables:
;; outline-regexp: ";;;;* "
;; End: No, |
Thanks, I agree that it is better to do this in local dev setup, fixed it in 42dfb7e. |
@raxod502 I add |
Thanks! |
Hmm, I somehow like my reduced outline. It is an outline after all - only showing the public API to give an overview :) |
[radian-software/selectrum#437] Use default outline-regexp
You change the value of
outline-regexp
.Please consider using the default value for elisp files instead:
";;;\\(;* [^ \t\n]\\|###autoload\\)\\|("
. It is a feature that top-level code blocks are treated as outline headings. If you don't want to use that or even consider it a misfeature, then that's fine, but please do not force your preference on others.You might also want to take my
bicycle
package for a ride. Using that to cycle through the supported visibility states in libraries that use the default regexp and then also in your libraries, should give you a good idea of why it is nice to treat code blocks as sections as well.Please revert this setting also in
prescient
,ctrlf
and any other packages were you are currently using the inferior regexp.Also consider my
outline-minor-faces
package for better visual effects. I am also mentioning this because inconsult
@minad uses some weird compromise, which I hope he will revert as well:";;;;* \\|(def\\(un\\|custom\\|var\\) consult-[a-z]"
.@minad Please don't hide "non-consult" top-level forms. Additionally this causes
outline-minor-faces
to highlight the first line of code-blocks like "real headings". ((defun consult--default-completion-candidate () ...
and(provide 'consult)
for example should not be hidden.)The handling around
outline-regexp
is weird and comes with uncommitted caveats, especially inemacs-lisp-mode
. If you change this without first readingoutline.el
, then you are almost certain to break something. It's quite unfortunate but also what we have to live with.The text was updated successfully, but these errors were encountered: