This repository has been archived by the owner on May 30, 2021. It is now read-only.
changePlaybackPositionCommand を無効に #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedom
reviewed
Feb 16, 2021
| let changePlaybackPositionCommand = remoteCommandCenter!.changePlaybackPositionCommand | ||
| changePlaybackPositionCommand.isEnabled = true | ||
| changePlaybackPositionCommand.addTarget(handler: self.onChangePlaybackPositionCommand) | ||
| // Radiko では seek, skip はCMとのからみがあるので許可しないため無効にする |
There was a problem hiding this comment.
念のため、#ifdefみたいなので機能無効にしておきたいですね
- 仕様差分の把握を容易に
- 将来的な仕様変更への備え
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
経緯
Radiko の仕様的にCM飛ばしが出来る操作は許可しないとのことなので無効にしました。
https://radikohq.slack.com/archives/G01275MPKHV/p1612939992488700?thread_ts=1612938742.483200&cid=G01275MPKHV