Add appsettings to de configmap in chart #5720
Conversation
youngbupark
changed the title
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Test Results2 699 tests ±0 2 692 ✔️ ±0 1m 57s ⏱️ -6s Results for commit 38dbe72. ± Comparison against base commit b6214b1. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
For the detailed report, please go to
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
# Description This is to add appsettings.Production.json to configmap to enable user to configure appsettings for DE. ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #5694 ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at d635aee</samp> ### Summary 📝🛠️🚀 <!-- 1. 📝 - This emoji represents the addition of a new ConfigMap resource, which is a text-based file that contains key-value pairs for configuration settings. The emoji can also imply documentation or writing. 2. 🛠️ - This emoji represents the update of the bicep-de deployment to use the ConfigMap as the configuration source, which is a technical or engineering change that involves fixing or improving something. The emoji can also imply tools or construction. 3. 🚀 - This emoji represents the enhancement of the bicep-de service by externalizing the configuration and making it easier to manage and update, which is a positive or exciting change that involves launching or deploying something. The emoji can also imply speed or performance. --> This pull request introduces a ConfigMap-based configuration for the `bicep-de` service. It modifies the `deploy/Chart/templates/de/deployment.yaml` and `deploy/Chart/templates/de/configmaps.yaml` files to use the ConfigMap as the source of the appsettings.Production.json file. > _Oh we're the bicep-de crew and we know what to do_ > _We use a ConfigMap to keep our settings true_ > _Heave away, haul away, on the count of three_ > _We'll deploy our service to the Kubernetes sea_ ### Walkthrough * Add a new ConfigMap resource `bicep-de-config` to store the appsettings.Production.json file for the bicep-de service ([link](https://github.com/project-radius/radius/pull/5720/files?diff=unified&w=0#diff-abdbdf0bf9bc402fbc09f6a4d1cd8bf66e6a3af2566a717caf8e60ddb467316eR1-R29)) * Mount the ConfigMap as a volume `appsettings-vol` in the bicep-de deployment spec and set the `ASPNETCORE_ENVIRONMENT` variable to `Production` ([link](https://github.com/project-radius/radius/pull/5720/files?diff=unified&w=0#diff-aa649ac3a27b3a57cd4da52d741118f2870fd721886d603f5091a90fc825e025R30-R33), [link](https://github.com/project-radius/radius/pull/5720/files?diff=unified&w=0#diff-aa649ac3a27b3a57cd4da52d741118f2870fd721886d603f5091a90fc825e025L35-R45)) * Remove the redundant environment variable `ASPNETCORE_Logging__LogLevel__Default` from the bicep-de container spec ([link](https://github.com/project-radius/radius/pull/5720/files?diff=unified&w=0#diff-aa649ac3a27b3a57cd4da52d741118f2870fd721886d603f5091a90fc825e025L46-L47))
Description
This is to add appsettings.Production.json to configmap to enable user to configure appsettings for DE.
Issue reference
Fixes: radius-project/core-team#1209
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Auto-generated summary
🤖 Generated by Copilot at d635aee
Summary
📝🛠️🚀
This pull request introduces a ConfigMap-based configuration for the
bicep-deservice. It modifies thedeploy/Chart/templates/de/deployment.yamlanddeploy/Chart/templates/de/configmaps.yamlfiles to use the ConfigMap as the source of the appsettings.Production.json file.Walkthrough
bicep-de-configto store the appsettings.Production.json file for the bicep-de service (link)appsettings-volin the bicep-de deployment spec and set theASPNETCORE_ENVIRONMENTvariable toProduction(link, link)ASPNETCORE_Logging__LogLevel__Defaultfrom the bicep-de container spec (link)