Fix RC release version tag in chart #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Test Results2 699 tests ±0 2 692 ✔️ ±0 2m 0s ⏱️ -2s Results for commit bc1797e. ± Comparison against base commit 18d0467. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. |
|
For the detailed report, please go to
|
rynowak
approved these changes
Jun 15, 2023
nithyatsu
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description I forgot the fact that we used the full version for rc image tag in the previous refactoring. This is the fix to use the correct tag for RC release. I validated it by creating manifest yaml. ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at bc1797e</samp> ### Summary 🏷️🧪📝 <!-- 1. 🏷️ - This emoji represents the change of the image tag from `latest` to `edge` and the modification of the `radius.versiontag` function to handle release candidate versions. The emoji is commonly used to denote labels, tags, or categories. 2. 🧪 - This emoji represents the use of the `edge` tag for the development branch of the Radius repository, which implies that the application is undergoing testing and experimentation. The emoji is commonly used to denote testing, science, or experiments. 3. 📝 - This emoji represents the addition of comments to the `radius.versiontag` function to clarify the logic and the purpose of the function. The emoji is commonly used to denote writing, documentation, or notes. --> Updated the Helm chart files for the Radius application to use the `edge` tag for the development branch and to handle release candidate versions in the label format. > _`appVersion` changed_ > _`radius.versiontag` too_ > _Helm chart adapts - spring_ ### Walkthrough * Update the image tag of the Radius application to `edge` for the development branch ([link](https://github.com/project-radius/radius/pull/5727/files?diff=unified&w=0#diff-f284fdc3b5faa17316f1b96af55e098431733d6fce3b615d201317539cfaf2d3L7-R7)) * Improve the `radius.versiontag` template function to handle release candidate versions and add comments ([link](https://github.com/project-radius/radius/pull/5727/files?diff=unified&w=0#diff-0ba89421395856d6246fed28806565a0d3475d08fdd81093c97091a888ef6529L4-R9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I forgot the fact that we used the full version for rc image tag in the previous refactoring. This is the fix to use the correct tag for RC release. I validated it by creating manifest yaml.
Issue reference
Fixes: #issue_number
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Auto-generated summary
🤖 Generated by Copilot at bc1797e
Summary
🏷️🧪📝
Updated the Helm chart files for the Radius application to use the
edgetag for the development branch and to handle release candidate versions in the label format.Walkthrough
edgefor the development branch (link)radius.versiontagtemplate function to handle release candidate versions and add comments (link)