Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace radius.dev and some instances of radapp.dev with radapp.io #6357

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

willdavsmith
Copy link
Contributor

@willdavsmith willdavsmith commented Sep 27, 2023

Description

  • Replaced all instances of radius.dev with radapp.io
  • Replaced instances of radapp.dev with radapp.io only in swagger examples

Recipes update: radius-project/recipes#33

Type of change

  • This pull request adds or changes features of Radius and has an approved issue (issue link required).

Fixes: #5285

Auto-generated summary

πŸ€– Generated by Copilot at ef89e72

Summary

🌐🏷️πŸ§ͺ

This pull request updates the domain name, label names, and test data in various files to reflect the new branding and deployment of the Radius project as radapp.io. It affects the armrpc, corerp, and cli packages and their subpackages. It ensures consistency and compatibility between the code, the API, and the test cases.

Oh we're the crew of the radapp.io
And we're changing all the test data
We'll heave away and haul away
With every pull request we make

Walkthrough

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Radius functional test overview

πŸ” Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6357/merge
Unique ID 8b054e7def
Image tag pr-8b054e7def
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-8b054e7def
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-8b054e7def
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-8b054e7def
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

βŒ› Building Radius and pushing container images for functional tests...
βœ… Container images build succeeded
βŒ› Publishing Bicep Recipes for functional tests...
βœ… Recipe publishing succeeded
βŒ› Starting datastoresrp functional tests...
βŒ› Starting msgrp functional tests...
βŒ› Starting daprrp functional tests...
βŒ› Starting shared functional tests...
βŒ› Starting samples functional tests...
βŒ› Starting ucp functional tests...
βœ… datastoresrp functional tests succeeded
βœ… samples functional tests succeeded
βœ… msgrp functional tests succeeded
βœ… ucp functional tests succeeded
βœ… daprrp functional tests succeeded
βœ… shared functional tests succeeded

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Test Results

2β€ˆ981 tests  Β±0   2β€ˆ972 βœ”οΈ Β±0   2m 18s ⏱️ +10s
βŸβ€„β€ˆ253 suites Β±0β€‚β€ƒβ€ƒβŸβ€„β€ˆβŸβ€„βŸβ€„9 πŸ’€ Β±0 
βŸβ€„β€ˆβŸβ€„βŸβ€„1 files   Β±0β€‚β€ƒβ€ƒβŸβ€„β€ˆβŸβ€„βŸβ€„0 ❌ Β±0 

Results for commit dabdea0. ± Comparison against base commit 4bda960.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/d1c37ca5-114c-4940-aeea-91dc2f9e16ae
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/d1c37ca5-114c-4940-aeea-91dc2f9e16ae#01
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/4c788e2e-6787-4cfb-8012-5a60762ea299
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/4c788e2e-6787-4cfb-8012-5a60762ea299#01

♻️ This comment has been updated with latest results.

@github-actions
Copy link

66.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 66.2 %
  • main branch coverage: 66.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.

  • Swagger changes require reference edge docs to be updated here
  • Make sure to create a branch and submit a PR into the edge branch instead of the default latest branch, as the swagger changes will not be available until the next release.

For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/.

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Radius functional test overview

πŸ” Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6357/merge
Unique ID 9e05ddccbc
Image tag pr-9e05ddccbc
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-9e05ddccbc
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-9e05ddccbc
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-9e05ddccbc
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

βŒ› Building Radius and pushing container images for functional tests...
βœ… Container images build succeeded
βŒ› Publishing Bicep Recipes for functional tests...
βœ… Recipe publishing succeeded
βŒ› Starting msgrp functional tests...
βŒ› Starting samples functional tests...
βŒ› Starting daprrp functional tests...
βŒ› Starting ucp functional tests...
βŒ› Starting shared functional tests...
βŒ› Starting datastoresrp functional tests...
βœ… datastoresrp functional tests succeeded
βœ… ucp functional tests succeeded
βœ… msgrp functional tests succeeded
βœ… samples functional tests succeeded
βœ… daprrp functional tests succeeded
βœ… shared functional tests succeeded

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Radius functional test overview

πŸ” Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6357/merge
Unique ID 282a2568a7
Image tag pr-282a2568a7
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-282a2568a7
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-282a2568a7
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-282a2568a7
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

βŒ› Building Radius and pushing container images for functional tests...
βœ… Container images build succeeded
βŒ› Publishing Bicep Recipes for functional tests...
βœ… Recipe publishing succeeded
βŒ› Starting datastoresrp functional tests...
βŒ› Starting samples functional tests...
βŒ› Starting msgrp functional tests...
βŒ› Starting ucp functional tests...
βŒ› Starting daprrp functional tests...
βŒ› Starting shared functional tests...
βœ… samples functional tests succeeded
βœ… datastoresrp functional tests succeeded
βœ… ucp functional tests succeeded
βœ… msgrp functional tests succeeded
βœ… daprrp functional tests succeeded
βœ… shared functional tests succeeded

@github-actions
Copy link

You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.

  • Swagger changes require reference edge docs to be updated here
  • Make sure to create a branch and submit a PR into the edge branch instead of the default latest branch, as the swagger changes will not be available until the next release.

For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/.

@willdavsmith willdavsmith changed the title [WIP/Do not review] Replace radius.dev with radapp.io Replace radius.dev and some instances of radapp.dev with radapp.io Sep 28, 2023
@willdavsmith willdavsmith marked this pull request as ready for review September 28, 2023 13:21
@willdavsmith willdavsmith requested review from a team as code owners September 28, 2023 13:21
@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Radius functional test overview

πŸ” Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6357/merge
Unique ID c56e19a19c
Image tag pr-c56e19a19c
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-c56e19a19c
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-c56e19a19c
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-c56e19a19c
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

βŒ› Building Radius and pushing container images for functional tests...
βœ… Container images build succeeded
βŒ› Publishing Bicep Recipes for functional tests...
βœ… Recipe publishing succeeded
βŒ› Starting daprrp functional tests...
βŒ› Starting ucp functional tests...
βŒ› Starting msgrp functional tests...
βŒ› Starting samples functional tests...
βŒ› Starting shared functional tests...
βŒ› Starting datastoresrp functional tests...
βœ… samples functional tests succeeded
βœ… datastoresrp functional tests succeeded
βœ… ucp functional tests succeeded
βœ… msgrp functional tests succeeded
βœ… daprrp functional tests succeeded
❌ shared functional test failed. Please check the logs for more details

@github-actions
Copy link

You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.

  • Swagger changes require reference edge docs to be updated here
  • Make sure to create a branch and submit a PR into the edge branch instead of the default latest branch, as the swagger changes will not be available until the next release.

For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/.

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Radius functional test overview

πŸ” Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6357/merge
Unique ID 9a373f0605
Image tag pr-9a373f0605
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-9a373f0605
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-9a373f0605
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-9a373f0605
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

βŒ› Building Radius and pushing container images for functional tests...
βœ… Container images build succeeded
βŒ› Publishing Bicep Recipes for functional tests...
βœ… Recipe publishing succeeded
βŒ› Starting samples functional tests...
βŒ› Starting shared functional tests...
βŒ› Starting daprrp functional tests...
βŒ› Starting ucp functional tests...
βŒ› Starting msgrp functional tests...
βŒ› Starting datastoresrp functional tests...
βœ… samples functional tests succeeded
βœ… datastoresrp functional tests succeeded
βœ… ucp functional tests succeeded
βœ… msgrp functional tests succeeded
βœ… daprrp functional tests succeeded
βœ… shared functional tests succeeded

@github-actions
Copy link

66.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 66.2 %
  • main branch coverage: 66.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@@ -25,7 +25,7 @@ resource redis 'apps/Deployment@v1' = {
resource: name

// Label pods with the application name so `rad run` can find the logs.
'radius.dev/application': application == '' ? '' : application
'radapp.io/application': application == '' ? '' : application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Recipes will need an update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LabelRadiusResource = "radapp.io/resource"
LabelRadiusDeployment = "radapp.io/deployment"
LabelRadiusRouteFmt = "radapp.io/route-%s-%s"
LabelRadiusResourceType = "radapp.io/resource-type"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @ytimocin - these labels are changing. Their purpose is still the same, just the names are changing.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.

  • Swagger changes require reference edge docs to be updated here
  • Make sure to create a branch and submit a PR into the edge branch instead of the default latest branch, as the swagger changes will not be available until the next release.

For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Radius functional test overview

πŸ” Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6357/merge
Unique ID 76205659fc
Image tag pr-76205659fc
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-76205659fc
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-76205659fc
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-76205659fc
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

βŒ› Building Radius and pushing container images for functional tests...
βœ… Container images build succeeded
βŒ› Publishing Bicep Recipes for functional tests...
βœ… Recipe publishing succeeded
βŒ› Starting datastoresrp functional tests...
βŒ› Starting daprrp functional tests...
βŒ› Starting msgrp functional tests...
βŒ› Starting samples functional tests...
βŒ› Starting shared functional tests...
βœ… datastoresrp functional tests succeeded
βœ… ucp functional tests succeeded
βœ… samples functional tests succeeded
βœ… msgrp functional tests succeeded
βœ… daprrp functional tests succeeded
βœ… shared functional tests succeeded

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

66.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 66.2 %
  • main branch coverage: 66.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@willdavsmith willdavsmith merged commit 1741cb3 into main Oct 3, 2023
26 of 27 checks passed
@willdavsmith willdavsmith deleted the willdavsmith/radappio branch October 3, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old Radius RP prefixes from Kubernetes labels
4 participants