remove connections as alias #7531

nithyatsu · 2024-04-23T23:25:26Z

Description

Removing "connections" as alias for "graph" command.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #7262

codecov · 2024-04-23T23:34:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (a6aa42e) to head (c6882b2).

❗ Current head c6882b2 differs from pull request most recent head eb5bb3b. Consider uploading reports for the commit eb5bb3b to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7531      +/-   ##
==========================================
- Coverage   63.58%   63.58%   -0.01%     
==========================================
  Files         414      414              
  Lines       23310    23309       -1     
==========================================
- Hits        14822    14821       -1     
  Misses       7225     7225              
  Partials     1263     1263

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-04-23T23:37:26Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`625969c`
Unique ID	funcedef90f6ec
Image tag	pr-funcedef90f6ec

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcedef90f6ec
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcedef90f6ec
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcedef90f6ec
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcedef90f6ec
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting cli functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
❌ daprrp functional test failed. Please check the logs for more details
❌ shared functional test cancelled. Please check the logs for more details
❌ cli functional test cancelled. Please check the logs for more details

pkg/cli/cmd/app/graph/graph.go

radius-functional-tests · 2024-04-25T22:35:29Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`de36c72`
Unique ID	func64427b7e84
Image tag	pr-func64427b7e84

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func64427b7e84
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func64427b7e84
controller test image location: ghcr.io/radius-project/dev/controller:pr-func64427b7e84
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func64427b7e84
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting cli functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting kubernetes functional tests...
❌ msgrp functional test failed. Please check the logs for more details
❌ ucp functional test cancelled. Please check the logs for more details
❌ cli functional test cancelled. Please check the logs for more details
❌ shared functional test cancelled. Please check the logs for more details
❌ samples functional test cancelled. Please check the logs for more details
❌ kubernetes functional test cancelled. Please check the logs for more details

radius-functional-tests · 2024-04-25T22:58:47Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`df3a2ef`
Unique ID	funcd03f2e2a1b
Image tag	pr-funcd03f2e2a1b

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd03f2e2a1b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd03f2e2a1b
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd03f2e2a1b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd03f2e2a1b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ samples functional tests succeeded
✅ shared functional tests succeeded

radius-functional-tests · 2024-04-25T23:21:35Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`72ad5a5`
Unique ID	func3321d6d714
Image tag	pr-func3321d6d714

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3321d6d714
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3321d6d714
controller test image location: ghcr.io/radius-project/dev/controller:pr-func3321d6d714
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3321d6d714
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ samples functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

radius-functional-tests · 2024-04-26T15:45:54Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`b7c0476`
Unique ID	funcd8075152fa
Image tag	pr-funcd8075152fa

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd8075152fa
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd8075152fa
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd8075152fa
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd8075152fa
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting cli functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ samples functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

ytimocin · 2024-04-26T16:10:17Z

pkg/cli/cmd/app/graph/graph_test.go

@@ -113,6 +113,7 @@ func Test_Validate(t *testing.T) {
 func Test_Run(t *testing.T) {
 	// This example is a very simple example of the application graph as an integration test.
 	// The unit tests for this package cover the more complex cases.
+


nit: do we need this extra line?

radius-functional-tests · 2024-04-26T17:57:59Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`c6882b2`
Unique ID	func64e7e69ac3
Image tag	pr-func64e7e69ac3

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func64e7e69ac3
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func64e7e69ac3
controller test image location: ghcr.io/radius-project/dev/controller:pr-func64e7e69ac3
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func64e7e69ac3
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting cli functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ samples functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

radius-functional-tests · 2024-04-26T18:59:02Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`eb5bb3b`
Unique ID	func3daa837bba
Image tag	pr-func3daa837bba

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3daa837bba
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3daa837bba
controller test image location: ghcr.io/radius-project/dev/controller:pr-func3daa837bba
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3daa837bba
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting shared functional tests...
⌛ Starting cli functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ cli functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

ytimocin

This comment should also be addresses.

nithyatsu requested review from a team as code owners April 23, 2024 23:25

nithyatsu temporarily deployed to functional-tests April 23, 2024 23:36 — with GitHub Actions Inactive

youngbupark reviewed Apr 24, 2024

View reviewed changes

pkg/cli/cmd/app/graph/graph.go Show resolved Hide resolved

nithyatsu temporarily deployed to functional-tests April 25, 2024 22:34 — with GitHub Actions Inactive

nithyatsu force-pushed the rem_conn_alias branch from de36c72 to df3a2ef Compare April 25, 2024 22:54

nithyatsu temporarily deployed to functional-tests April 25, 2024 22:58 — with GitHub Actions Inactive

nithyatsu force-pushed the rem_conn_alias branch from df3a2ef to 72ad5a5 Compare April 25, 2024 23:17

nithyatsu temporarily deployed to functional-tests April 25, 2024 23:20 — with GitHub Actions Inactive

nithyatsu force-pushed the rem_conn_alias branch from 5031860 to b7c0476 Compare April 26, 2024 15:34

nithyatsu temporarily deployed to functional-tests April 26, 2024 15:45 — with GitHub Actions Inactive

nithyatsu requested a review from youngbupark April 26, 2024 15:57

ytimocin reviewed Apr 26, 2024

View reviewed changes

nithyatsu force-pushed the rem_conn_alias branch from d632f27 to c6882b2 Compare April 26, 2024 17:46

nithyatsu temporarily deployed to functional-tests April 26, 2024 17:57 — with GitHub Actions Inactive

nithyatsu added 6 commits April 26, 2024 11:56

remove connections as alias

42dd240

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

nit

2b797d9

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

wip

9bdbe46

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

qdw

3f46db7

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

fix

65222b0

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

nit rem extra space

eb5bb3b

Signed-off-by: nithyatsu <nithyasu@microsoft.com>

nithyatsu force-pushed the rem_conn_alias branch from c6882b2 to eb5bb3b Compare April 26, 2024 18:56

nithyatsu temporarily deployed to functional-tests April 26, 2024 18:58 — with GitHub Actions Inactive

nithyatsu requested a review from ytimocin April 26, 2024 19:59

ytimocin approved these changes Apr 26, 2024

View reviewed changes

youngbupark approved these changes Apr 26, 2024

View reviewed changes

youngbupark merged commit e59b3ac into radius-project:main Apr 26, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove connections as alias #7531

remove connections as alias #7531

nithyatsu commented Apr 23, 2024

codecov bot commented Apr 23, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 23, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 25, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 25, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 25, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 26, 2024 •

edited

Loading

ytimocin Apr 26, 2024

radius-functional-tests bot commented Apr 26, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 26, 2024 •

edited

Loading

ytimocin left a comment

remove connections as alias #7531

remove connections as alias #7531

Conversation

nithyatsu commented Apr 23, 2024

Description

Type of change

codecov bot commented Apr 23, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Apr 23, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Apr 25, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Apr 25, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Apr 25, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Apr 26, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin Apr 26, 2024

Choose a reason for hiding this comment

radius-functional-tests bot commented Apr 26, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Apr 26, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 23, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 23, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 25, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 25, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 25, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 26, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 26, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 26, 2024 •

edited

Loading