Update purge test resources (both azure and aws) workflows #7551
Conversation
ytimocin
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
| @@ -93,5 +93,17 @@ jobs: | |||
| cat ${{ env.AZURE_RG_DELETE_LIST_FILE}} | while read line | |||
| do | |||
| echo " * $line" >> $GITHUB_STEP_SUMMARY | |||
| az group delete --resource-group $line --yes --verbose | |||
| az group delete --resource-group $line --yes --verbose --no-wait | |||
There was a problem hiding this comment.
I think that because we have a lot of resource groups, it takes more than 5 minutes to delete them. Within that 5 minutes, the session loses its access because login is only granted for 5 minutes. Please see: Azure/login#372.
I may be wrong about this. Open to suggestions. cc/ @youngbupark
There was a problem hiding this comment.
I think this is a similar issue to this one: #7494. There was a regression in the az cli with the login expiration so they provided some workarounds here: Azure/azure-cli#28737 (comment)
But we already use a service principal and that still seems to be failing for us. I think they plan to release a fix on 4/30 so we may need to revisit this once that version is out
There was a problem hiding this comment.
Looks like az login issues 5 mins expiry token. I am ok to add --no-wait. The fix will be released in 2.60 CLI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7551 +/- ##
==========================================
- Coverage 60.33% 60.32% -0.02%
==========================================
Files 517 517
Lines 26432 26432
==========================================
- Hits 15948 15945 -3
- Misses 9138 9139 +1
- Partials 1346 1348 +2 ☔ View full report in Codecov by Sentry. |
| @@ -40,3 +40,15 @@ jobs: | |||
| - name: Delete old AWS resources | |||
| run: | | |||
| ./.github/scripts/delete-aws-resources.sh ${{ env.AWS_RESOURCE_TYPES }} | |||
| - name: Create issue for failing purge aws test resources run | |||
There was a problem hiding this comment.
Don't you think it is too verbose?
| done | ||
| - name: Create issue for failing purge test resources run |
There was a problem hiding this comment.
I do not think we need this.. it is too verbose and noisy.
There was a problem hiding this comment.
Don't you think that we should know if this workflow fails? Otherwise, we may only understand when we hit resource limits. Happy to discuss further and listen to other ideas.
|
@ytimocin I do not think we need to create the issue for the deletion failure. It seems too noisy. other than this, lgtm. |
ytimocin
force-pushed
the
ytimocin/updatePurgeWorkflows
branch
from
ca3688d
to
cd230b2
Compare
This comment has been minimized.
This comment has been minimized.
|
⌛ Building Radius and pushing container images for functional tests... ✅ Container images build succeeded |
Signed-off-by: ytimocin <ytimocin@microsoft.com>
ytimocin
force-pushed
the
ytimocin/updatePurgeWorkflows
branch
from
cd230b2
to
66d38a2
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
Update purge test resources (both azure and aws) workflows
Type of change
Fixes:
AADSTS700024: Client assertion is not within its valid time rangeerror in Purge Test Resources workflow #7550