Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade controller-gen to 0.15.0 #7556

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

youngbupark
Copy link

@youngbupark youngbupark commented Apr 28, 2024

Description

To upgrade golang 1.22.x, we first need to use the latest controller-gen due to the indirect package which is incompatible with 1.22.x.

golang 1.22 has test coverage drop issue. I extracted controller-gen update part from #7533

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Signed-off-by: Young Bu Park <youngp@microsoft.com>
@youngbupark youngbupark requested review from a team as code owners April 28, 2024 10:30
@radius-functional-tests
Copy link

radius-functional-tests bot commented Apr 28, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository youngbupark/radius
Commit ref f051159
Unique ID funcf4e597e470
Image tag pr-funcf4e597e470
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcf4e597e470
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcf4e597e470
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcf4e597e470
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcf4e597e470
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting cli functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (e59b3ac) to head (f051159).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7556   +/-   ##
=======================================
  Coverage   63.58%   63.59%           
=======================================
  Files         414      414           
  Lines       23309    23309           
=======================================
+ Hits        14821    14823    +2     
+ Misses       7225     7224    -1     
+ Partials     1263     1262    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@youngbupark youngbupark merged commit d7ea006 into radius-project:main Apr 29, 2024
16 checks passed
@youngbupark youngbupark deleted the youngp/upgrade-cgen branch April 29, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants