Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go to 1.22.2 #7559

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

youngbupark
Copy link

Description

This is to upgrade to 1.22.2. However we might need to wait until the fix for coverage drop issue is ready - golang/go#65570

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Signed-off-by: Young Bu Park <youngp@microsoft.com>
@youngbupark youngbupark requested review from a team as code owners April 29, 2024 12:05
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.25%. Comparing base (df0551d) to head (b672355).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7559      +/-   ##
==========================================
- Coverage   63.59%   60.25%   -3.35%     
==========================================
  Files         414      507      +93     
  Lines       23309    26265    +2956     
==========================================
+ Hits        14823    15825    +1002     
- Misses       7224     9105    +1881     
- Partials     1262     1335      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rynowak
Copy link
Contributor

rynowak commented Apr 29, 2024

This is to upgrade to 1.22.2. However we might need to wait until the fix for coverage drop issue is ready - golang/go#65570

I don't see any ETA for a fix (or acknowledgment that it's being fixed). Some options:

  • Do the upgrade anyway. This doesn't actually change what we've got tests for in Radius, it just moves the baseline down.
  • Apply this workaround

Copy link
Contributor

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good

@radius-functional-tests
Copy link

radius-functional-tests bot commented May 1, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository youngbupark/radius
Commit ref b672355
Unique ID func431dd7ee4f
Image tag pr-func431dd7ee4f
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func431dd7ee4f
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func431dd7ee4f
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func431dd7ee4f
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func431dd7ee4f
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting cli functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ cli functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@youngbupark youngbupark merged commit bb49384 into radius-project:main May 1, 2024
16 checks passed
@youngbupark youngbupark deleted the youngp/go122 branch May 1, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants