Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip - do not review] Bicep compiler merge #7662

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Jun 4, 2024

Description

Feature branch PR for all bicep compiler related changes

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number


Description

Please explain the changes you've made.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Copy link

github-actions bot commented Jun 4, 2024

Unit Tests

3 218 tests  ±0   3 212 ✅ ±0   4m 6s ⏱️ +5s
  261 suites ±0       6 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit fed2462. ± Comparison against base commit 0b6ecc0.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.01%. Comparing base (0b6ecc0) to head (fed2462).

Files Patch % Lines
pkg/cli/bicep/tools/download_tools.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7662   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files         520      520           
  Lines       27010    27008    -2     
=======================================
  Hits        16480    16480           
+ Misses       9079     9077    -2     
  Partials     1451     1451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from b0c0b67 to edd635a Compare June 4, 2024 16:09
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from 8cd2aef to edd635a Compare June 4, 2024 16:12
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from 2f03113 to edd635a Compare June 4, 2024 16:40
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from edd635a to 262a6cf Compare June 4, 2024 16:40
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from 262a6cf to d0cf79c Compare June 4, 2024 16:55
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from d0cf79c to f3326e9 Compare June 5, 2024 21:52
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from f3326e9 to 1fbf58f Compare June 12, 2024 16:52
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from 1fbf58f to 5905aad Compare June 12, 2024 21:10
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from 5905aad to 4a8e327 Compare June 12, 2024 21:31
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from 4a8e327 to dd97afb Compare June 12, 2024 21:50
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from dd97afb to 66c3b66 Compare June 12, 2024 23:22
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from 66c3b66 to 52a1a4b Compare June 12, 2024 23:27
@radius-functional-tests

This comment has been minimized.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 18, 2024

⌛ Building Radius and pushing container images for functional tests...

✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
❌ Test recipe publishing failed

@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from f65a916 to 995873b Compare June 18, 2024 21:35
@sk593 sk593 temporarily deployed to functional-tests June 18, 2024 21:35 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 995873b
Unique ID funca757cf6c43
Image tag pr-funca757cf6c43
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca757cf6c43
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca757cf6c43
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funca757cf6c43
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca757cf6c43
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
❌ Test recipe publishing failed

@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from 995873b to d9af59d Compare June 18, 2024 22:48
@sk593 sk593 force-pushed the feature-bicep-compiler-merge branch from d9af59d to bb8da88 Compare June 19, 2024 21:55
# Description

Update bicep generator to use bicep-types and new contract

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #issue_number

---------

Signed-off-by: sk593 <shruthikumar@microsoft.com>
# Description

Update rad bicep download to download the official bicep compiler

<img width="679" alt="Screenshot 2024-06-03 at 10 45 00 PM"
src="https://github.com/radius-project/radius/assets/42750942/70b36aef-701b-484e-aa25-d690146126ce">
[downloading the official release 0.27.1 instead of our release version
0.34]

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #issue_number

---------

Signed-off-by: sk593 <shruthikumar@microsoft.com>
# Description

Update build workflow to publish bicep types to ACR

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #issue_number

---------

Signed-off-by: sk593 <shruthikumar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant