-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting functional tests as cloud and non-cloud #7716
base: main
Are you sure you want to change the base?
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
be8b05c
to
7f788b7
Compare
7f788b7
to
c7d47e6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7716 +/- ##
=======================================
Coverage 60.99% 61.00%
=======================================
Files 520 520
Lines 27010 27010
=======================================
+ Hits 16476 16478 +2
+ Misses 9081 9080 -1
+ Partials 1453 1452 -1 ☔ View full report in Codecov by Sentry. |
c7d47e6
to
ab8b940
Compare
❌ Container images build failed ❌ Test recipe publishing failed |
ab8b940
to
8ccc61d
Compare
This comment has been minimized.
This comment has been minimized.
⌛ Building Radius and pushing container images for functional tests... ✅ Container images build succeeded |
8ccc61d
to
399a3c3
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
399a3c3
to
afefa5b
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
afefa5b
to
273fd42
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
which rad || { echo "cannot find rad"; exit 1; } | ||
|
||
echo "*** Installing Radius to Kubernetes ***" | ||
rad install kubernetes \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting this error: *** Installing Radius to Kubernetes *** Installing Radius version afefa5b to namespace: radius-system... Error: failed to run Radius Helm install, err: cannot re-use a name that is still in use Helm output: getting history for release radius creating 1 resource(s) creating 1 resource(s) creating 1 resource(s) beginning wait for 3 resources with timeout of 1m0s
.
Link to an example run: https://github.com/radius-project/radius/actions/runs/9659072267/job/26641840926.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added --reinstall
flag and retesting: https://github.com/radius-project/radius/actions/runs/9662144721.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting the same error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing --reinstall
.
273fd42
to
e6aa7c0
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
e6aa7c0
to
530192c
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: ytimocin <ytimocin@microsoft.com>
530192c
to
75f36e2
Compare
Radius functional test (non-cloud) overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
The goal of this PR is to create another workflow to run functional tests that don't use cloud resources and also remove the non-cloud tests from the existing functional test workflow that requires approval. In brief:
RP tests that use cloud resources
RP tests that use non-cloud resources
Type of change
Fixes: github workflow changes to not require approval for non-cloud tests #7624