Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes required for eshop #24

Merged
merged 9 commits into from
Aug 10, 2023
Merged

Conversation

willdavsmith
Copy link
Contributor

@willdavsmith willdavsmith commented Jul 14, 2023

  • Add recipes which enable cross-cloud eshop

aws/rediscaches.bicep Outdated Show resolved Hide resolved
aws/sqldatabases.bicep Outdated Show resolved Hide resolved
aws/sqldatabases.bicep Outdated Show resolved Hide resolved
azure/sqldatabases.bicep Outdated Show resolved Hide resolved
azure/sqldatabases.bicep Outdated Show resolved Hide resolved
dev/rabbitmqmessagequeues.bicep Outdated Show resolved Hide resolved
@willdavsmith willdavsmith added the blocked Unable to proceed due to outside impediment label Jul 27, 2023
@willdavsmith
Copy link
Contributor Author

Blocked waiting on radius-project/core-team#604

@willdavsmith willdavsmith removed the blocked Unable to proceed due to outside impediment label Aug 7, 2023
Copy link
Contributor

@AaronCrawfis AaronCrawfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good! Couple small notes

aws/sqldatabases.bicep Outdated Show resolved Hide resolved
azure/servicebus.bicep Outdated Show resolved Hide resolved
}
}

output result object = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other properties we could pass back that might be useful to users?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with service bus or its usage - let me know if you have any ideas

@willdavsmith willdavsmith changed the title Adding recipes required for eshop Add recipes required for eshop Aug 8, 2023
@willdavsmith willdavsmith merged commit 7e1ef45 into main Aug 10, 2023
3 checks passed
@willdavsmith willdavsmith deleted the willdavsmith/eshop-recipes branch August 10, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants