SQL recipe updates #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
willdavsmith
commented
Oct 12, 2023
willdavsmith
commented
- Setting defaults for aws and azure sql recipes
|
|
||
| @description('SQL administrator password') | ||
| @secure() | ||
| param adminPassword string | ||
| param adminPassword string = newGuid() |
There was a problem hiding this comment.
Could you verify that deploying the application twice in a row works? I'm worried that deploying the application twice will result in the password changing, and then the container with the connection string as an environment variable won't get the password rotated.
There was a problem hiding this comment.
seems to work. I deployed it, tested the app, ran the deployment command again rad deploy eshop.bicep, and it still works.
AaronCrawfis
approved these changes
Oct 13, 2023
willdavsmith
added a commit
that referenced
this pull request
Oct 18, 2023
(cherry picked from commit 9d6a71e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.