Skip to content

Commit

Permalink
Use capture phase in useEscapeKeydown (#2761)
Browse files Browse the repository at this point in the history
* Use capture phase

* Create 75dcd823.yml
  • Loading branch information
benoitgrelard authored Mar 6, 2024
1 parent 2790136 commit d7f5ed5
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
18 changes: 18 additions & 0 deletions .yarn/versions/75dcd823.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
releases:
"@radix-ui/react-alert-dialog": patch
"@radix-ui/react-context-menu": patch
"@radix-ui/react-dialog": patch
"@radix-ui/react-dismissable-layer": patch
"@radix-ui/react-dropdown-menu": patch
"@radix-ui/react-hover-card": patch
"@radix-ui/react-menu": patch
"@radix-ui/react-menubar": patch
"@radix-ui/react-navigation-menu": patch
"@radix-ui/react-popover": patch
"@radix-ui/react-select": patch
"@radix-ui/react-toast": patch
"@radix-ui/react-tooltip": patch
"@radix-ui/react-use-escape-keydown": patch

declined:
- primitives
4 changes: 2 additions & 2 deletions packages/react/use-escape-keydown/src/useEscapeKeydown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ function useEscapeKeydown(
onEscapeKeyDown(event);
}
};
ownerDocument.addEventListener('keydown', handleKeyDown);
return () => ownerDocument.removeEventListener('keydown', handleKeyDown);
ownerDocument.addEventListener('keydown', handleKeyDown, { capture: true });
return () => ownerDocument.removeEventListener('keydown', handleKeyDown, { capture: true });
}, [onEscapeKeyDown, ownerDocument]);
}

Expand Down

0 comments on commit d7f5ed5

Please sign in to comment.