[DropdownMenu][ContextMenu][Menu] Only register a single set of event listeners for the entire document #3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when tracking whether a keyboard or a mouse is being used.
mleibman-db
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
Menucomponents more efficient when used in large numbers by only registering a single set of event listeners on thedocumentto track whether a user is using a keyboard or a mouse.This properly fixes #1239 and #1139.
I also saw that a similar change was attempted in #1252, but I'm proposing a much simpler implementation here.
P.S. I did read through the discussion in #1239, but we unfortunately do seem to be running into some performance issues due to having a huge number of React components including Menus on the page. While I agree that this is an issue in and of itself, I also think that it's great for UI libraries to be efficient and be able to scale well with a large number of component instances.