Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] fix: disabled select when fieldset has disabled attr #3174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Select] fix: disabled select when fieldset has disabled attr #3174

wants to merge 2 commits into from
+14 −1

Conversation

ojj1123
Copy link

@ojj1123 ojj1123 commented Oct 10, 2024 •
edited
Loading

Description

close #2417

  • When there is disabled fieldset, Select component does not be disabled.
  • This is because Select.Trigger has onPointerDown handler and even if button is disabled, that handler can be triggered.
  • So I added the code that check if there is fieldset disabled.

AS-IS

2024-10-10.14.42.50.mov

TO-BE

2024-10-10.14.42.00.mov

@ojj1123 ojj1123 mentioned this pull request Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenHaney StephenHaney Awaiting requested review from StephenHaney StephenHaney is a code owner

@vladmoroz vladmoroz Awaiting requested review from vladmoroz vladmoroz is a code owner

@lucasmotta lucasmotta Awaiting requested review from lucasmotta lucasmotta is a code owner

@hadihallak hadihallak Awaiting requested review from hadihallak hadihallak is a code owner

@chaance chaance Awaiting requested review from chaance chaance is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] Not inheriting disabled from parent fieldset
1 participant
@ojj1123