[bazel] Upgrade closure rules to 0.11.0

rafaelfranca · Nov 10, 2020 · 6b24560 · 6b24560
1 parent 83b2f46
commit 6b24560
Show file tree

Hide file tree

Showing 12 changed files with 91 additions and 18 deletions.
diff --git a/WORKSPACE b/WORKSPACE
@@ -78,19 +78,6 @@ load("@maven//:defs.bzl", "pinned_maven_install")
 
 pinned_maven_install()
 
-http_archive(
-    name = "io_bazel_rules_closure",
-    sha256 = "2e95ba060acd74f3662547a38814ffff60317be047b7168d25498aea52f3e732",
-    strip_prefix = "rules_closure-b3d4ec3879620edcadd3422b161cebb37c59b6c5",
-    urls = [
-        "https://github.com/bazelbuild/rules_closure/archive/b3d4ec3879620edcadd3422b161cebb37c59b6c5.tar.gz",
-    ],
-)
-
-load("@io_bazel_rules_closure//closure:defs.bzl", "closure_repositories")
-
-closure_repositories()
-
 http_archive(
     name = "d2l_rules_csharp",
     sha256 = "4e8e9a93a5436d81c0a410148bef9e3e44860cd7dc567dd4732ab5b269a5e1f8",
@@ -139,6 +126,21 @@ pip_install(
     requirements = "//py:requirements.txt",
 )
 
+http_archive(
+    name = "io_bazel_rules_closure",
+    sha256 = "d66deed38a0bb20581c15664f0ab62270af5940786855c7adc3087b27168b529",
+    strip_prefix = "rules_closure-0.11.0",
+    urls = [
+        "https://github.com/bazelbuild/rules_closure/archive/0.11.0.tar.gz",
+    ],
+)
+
+load("@io_bazel_rules_closure//closure:repositories.bzl", "rules_closure_dependencies", "rules_closure_toolchains")
+
+rules_closure_dependencies()
+
+rules_closure_toolchains()
+
 http_archive(
     name = "rules_pkg",
     sha256 = "aeca78988341a2ee1ba097641056d168320ecc51372ef7ff8e64b139516a4937",

diff --git a/javascript/atoms/BUILD.bazel b/javascript/atoms/BUILD.bazel
@@ -26,6 +26,7 @@ closure_js_library(
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     visibility = [
         "//javascript/atoms/fragments:__pkg__",
@@ -46,11 +47,17 @@ closure_js_library(
 closure_js_library(
     name = "bot",
     srcs = ["bot.js"],
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
 )
 
 closure_js_library(
     name = "color",
     srcs = ["color.js"],
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     deps = [
         "@io_bazel_rules_closure//closure/library",
     ],
@@ -70,6 +77,7 @@ closure_js_library(
         "JSC_NULLABLE_RETURN_WITH_NAME",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":bot",
@@ -89,6 +97,7 @@ closure_js_library(
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":errors",
@@ -105,6 +114,7 @@ closure_js_library(
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":bot",
@@ -128,6 +138,7 @@ closure_js_library(
         "JSC_MISSING_CONST_PROPERTY",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
 )
 
@@ -139,6 +150,7 @@ closure_js_library(
         "JSC_MISSING_CONST_PROPERTY",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":bot",
@@ -157,6 +169,7 @@ closure_js_library(
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_NULLABLE_RETURN_WITH_NAME",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     visibility = [
         "//javascript/webdriver/atoms/inject:__pkg__",
@@ -177,6 +190,7 @@ closure_js_library(
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_NULLABLE_RETURN_WITH_NAME",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":bot",
@@ -194,6 +208,7 @@ closure_js_library(
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     visibility = [
         "//javascript/atoms/fragments:__pkg__",
@@ -211,6 +226,9 @@ closure_js_library(
 closure_js_library(
     name = "json",
     srcs = ["json.js"],
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     deps = [
         ":useragent",
         "@io_bazel_rules_closure//closure/library",
@@ -228,6 +246,7 @@ closure_js_library(
         "JSC_LATE_PROVIDE_ERROR",
         "JSC_NULLABLE_RETURN_WITH_NAME",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":bot",
@@ -246,6 +265,7 @@ closure_js_library(
     suppress = [
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = ["@io_bazel_rules_closure//closure/library"],
 )
@@ -256,6 +276,9 @@ closure_js_library(
         "frame.js",
         "window.js",
     ],
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     deps = [
         ":bot",
         ":errors",
@@ -272,6 +295,7 @@ closure_js_library(
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":bot",
@@ -285,6 +309,9 @@ closure_js_library(
     name = "test_util",
     testonly = 1,
     srcs = ["test/test_util.js"],
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     deps = [
         ":useragent",
         "@io_bazel_rules_closure//closure/library",

diff --git a/javascript/atoms/dom.js b/javascript/atoms/dom.js
@@ -574,7 +574,7 @@ bot.dom.isShown = function(elem, opt_ignoreOpacity) {
   /**
    * Determines whether an element or its parents have `display: none` set
    * @param {!Node} e the element
-   * @return {boolean}
+   * @return {!boolean}
    */
   function displayed(e) {
     if (bot.dom.isElement(e)) {
@@ -609,7 +609,7 @@ bot.dom.isShown = function(elem, opt_ignoreOpacity) {
       return false;
     }
 
-    return parent && displayed(parent);
+    return !!parent && displayed(parent);
   }
 
   return bot.dom.isShown_(elem, !!opt_ignoreOpacity, displayed);

diff --git a/javascript/chrome-driver/BUILD.bazel b/javascript/chrome-driver/BUILD.bazel
@@ -10,6 +10,7 @@ closure_js_library(
         "JSC_PREFER_BACKTICKS_TO_AT_SIGN_CODE",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         "//javascript/atoms:dom",

diff --git a/javascript/ie-driver/BUILD.bazel b/javascript/ie-driver/BUILD.bazel
@@ -16,6 +16,7 @@ closure_js_library(
     ],
     suppress = [
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         "//javascript/atoms:dom",

diff --git a/javascript/remote/BUILD.bazel b/javascript/remote/BUILD.bazel
@@ -24,6 +24,7 @@ closure_js_library(
         "JSC_PREFER_BACKTICKS_TO_AT_SIGN_CODE",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         "//javascript/atoms:errors",

diff --git a/javascript/selenium-atoms/BUILD.bazel b/javascript/selenium-atoms/BUILD.bazel
@@ -17,14 +17,14 @@ closure_js_library(
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_MISSING_JSDOC",
         "JSC_MISSING_PARAMETER_JSDOC",
-        "JSC_MISSING_REQUIRE_STRICT_WARNING",
         "JSC_MISSING_RETURN_JSDOC",
         "JSC_MUST_BE_PRIVATE",
         "JSC_PREFER_BACKTICKS_TO_AT_SIGN_CODE",
         "JSC_PRIMITIVE_OBJECT",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
         "JSC_UNUSED_LOCAL_ASSIGNMENT",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         "//javascript/atoms:action",

diff --git a/javascript/webdriver/BUILD.bazel b/javascript/webdriver/BUILD.bazel
@@ -15,6 +15,7 @@ closure_js_library(
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_MISSING_CONST_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     visibility = ["//javascript/remote:__pkg__"],
     deps = [
@@ -26,13 +27,19 @@ closure_js_library(
 closure_js_library(
     name = "key",
     srcs = ["key.js"],
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     visibility = ["//javascript:__subpackages__"],
 )
 
 closure_js_library(
     name = "all_js_for_testing",
     testonly = 1,
     srcs = glob(["**/*.js"]),
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     visibility = ["//javascript:__pkg__"],
     deps = ["@io_bazel_rules_closure//closure/library"],
 )

diff --git a/javascript/webdriver/atoms/BUILD.bazel b/javascript/webdriver/atoms/BUILD.bazel
@@ -27,6 +27,7 @@ closure_js_library(
     suppress = [
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_NULLABLE_RETURN_WITH_NAME",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     visibility = ["//javascript:__subpackages__"],
     deps = [
@@ -44,6 +45,9 @@ closure_fragment(
     name = "clear-local-storage",
     function = "webdriver.atoms.storage.local.clear",
     module = "webdriver.atoms.storage.local",
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     visibility = [
         "//javascript/chrome-driver:__pkg__",
     ],
@@ -267,6 +271,9 @@ closure_js_library(
     name = "all_js_for_testing",
     testonly = 1,
     srcs = glob(["**/*.js"]),
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     visibility = [
         "//javascript:__pkg__",
         "//javascript/chrome-driver:__pkg__",

diff --git a/javascript/webdriver/atoms/inject/BUILD.bazel b/javascript/webdriver/atoms/inject/BUILD.bazel
@@ -31,6 +31,7 @@ closure_js_library(
     suppress = [
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":execute-script",
@@ -44,6 +45,9 @@ closure_js_library(
 closure_js_library(
     name = "appcache",
     srcs = ["appcache.js"],
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     deps = [
         "//javascript/atoms:inject",
         "//javascript/webdriver/atoms:atoms-lib",
@@ -56,6 +60,7 @@ closure_js_library(
     suppress = [
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":execute-script",
@@ -73,6 +78,7 @@ closure_js_library(
     suppress = [
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_NULLABLE_RETURN_WITH_NAME",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         "//javascript/atoms:inject",
@@ -85,6 +91,7 @@ closure_js_library(
     suppress = [
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":execute-script",
@@ -100,6 +107,7 @@ closure_js_library(
     suppress = [
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_NULLABLE_RETURN_WITH_NAME",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     deps = [
         ":execute-script",
@@ -110,6 +118,9 @@ closure_js_library(
 closure_js_library(
     name = "local-storage",
     srcs = ["local_storage.js"],
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     deps = [
         ":execute-script",
         "//javascript/webdriver/atoms:atoms-lib",
@@ -119,6 +130,9 @@ closure_js_library(
 closure_js_library(
     name = "session-storage",
     srcs = ["session_storage.js"],
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     deps = [
         ":execute-script",
         "//javascript/webdriver/atoms:atoms-lib",
@@ -128,6 +142,9 @@ closure_js_library(
 closure_js_library(
     name = "sql-database",
     srcs = ["sql_database.js"],
+    suppress = [
+        "JSC_USE_OF_GOOG_PROVIDE",
+    ],
     deps = [
         ":execute-script",
         "//javascript/atoms:errors",

diff --git a/third_party/js/wgxpath/BUILD.bazel b/third_party/js/wgxpath/BUILD.bazel
@@ -9,10 +9,10 @@ closure_js_library(
         "JSC_HIDDEN_SUPERCLASS_PROPERTY",
         "JSC_IMPLICITLY_NULLABLE_JSDOC",
         "JSC_MISSING_CONST_PROPERTY",
-        "JSC_MISSING_REQUIRE_STRICT_WARNING",
         "JSC_MISSING_SEMICOLON",
         "JSC_STRICT_INEXISTENT_PROPERTY",
         "JSC_UNKNOWN_EXPR_TYPE",
+        "JSC_USE_OF_GOOG_PROVIDE",
     ],
     visibility = ["//visibility:public"],
     deps = ["@io_bazel_rules_closure//closure/library"],