Updating Bazel build files to support .NET tests on non-Windows OSes

Sandboxing rules on non-Windows OSes mean that tests will not run properly unless the data attributes of the test target are fully available.
rafaelfranca · Apr 22, 2020 · 8ba74c1 · 8ba74c1
1 parent 7b09850
commit 8ba74c1
Show file tree

Hide file tree

Showing 6 changed files with 58 additions and 32 deletions.
diff --git a/dotnet/nunit-test.bzl b/dotnet/nunit-test.bzl
@@ -19,12 +19,6 @@ CORE_FRAMEWORK_VERSIONS = {
     "netcoreapp3.1": "3.1.1",
 }
 
-def _is_windows():
-    return select({
-        "@bazel_tools//src/conditions:windows": True,
-        "//conditions:default": False,
-    })
-
 def _write_runtimeconfig(ctx, target):
     tfm = target.actual_tfm
     runtimeconfig_file_name = "bazelout/%s/%s.runtimeconfig.json" % (tfm, target.out.basename.replace("." + target.out.extension, ""))
@@ -46,13 +40,26 @@ def _generate_execution_script_file(ctx, target):
     tfm = target.actual_tfm
     test_file_name = target.out.basename
     shell_file_extension = "sh"
-    shell_content = "$( cd \"$( dirname )\"$BASH_SOURCE[0]}\" )\" >/dev/null 2>&1 && pwd )/" + test_file_name + " $@"
-    if _is_windows():
+    execution_line = "$( cd \"$(dirname \"$BASH_SOURCE[0]}\")\" >/dev/null 2>&1 && pwd -P )/" + test_file_name + " $@"
+    if ctx.attr.is_windows:
         shell_file_extension = "bat"
-        shell_content = "%~dp0" + test_file_name + " %*"
+        execution_line = "%~dp0" + test_file_name + " %*"
 
     if is_core_framework(tfm):
-        shell_content = "dotnet " + shell_content
+        execution_line = "dotnet " + execution_line
+
+    dotnet_sdk_location = ""
+    environment = ""
+    if not ctx.attr.is_windows:
+        # This needs to be fixed here for non-Windows platforms.
+        environment += "export HOME=%s\n" % dotnet_sdk_location
+        environment += "export DOTNET_CLI_HOME=%s\n" % dotnet_sdk_location
+        environment += "export APPDATA=%s\n" % dotnet_sdk_location
+        environment += "export PROGRAMFILES=%s\n" % dotnet_sdk_location
+        environment += "export USERPROFILE=%s\n" % dotnet_sdk_location
+        environment += "export DOTNET_CLI_TELEMETRY_OPTOUT=1%s\n"
+
+    shell_content = environment + execution_line
 
     shell_file_name = "bazelout/%s/%s.%s" % (tfm, test_file_name, shell_file_extension)
     shell_file = ctx.actions.declare_file(shell_file_name)
@@ -121,7 +128,7 @@ def _copy_dependency_files(ctx, provider_value):
     src_list =  provider_value.transitive_runfiles.to_list()
     target_dir = "bazelout/%s/" % (provider_value.actual_tfm)
     dest_list = []
-    if _is_windows():
+    if ctx.attr.is_windows:
         dest_list = _copy_cmd(ctx, src_list, target_dir)
     else:
         dest_list = _copy_bash(ctx, src_list, target_dir)
@@ -258,6 +265,7 @@ nunit_test = rule(
             providers = AnyTargetFrameworkInfo,
             default = "@NUnit//:nunit.framework",
         ),
+        "is_windows": attr.bool(default=False),
     },
     test = True,
     executable = True,

diff --git a/dotnet/test/common/BUILD.bazel b/dotnet/test/common/BUILD.bazel
@@ -37,7 +37,11 @@ config_setting(
     data = [
         "appconfig.json",
         "//common/src/web",
+        "//java/client/test/org/openqa/selenium/environment:keystore",
         "//java/client/test/org/openqa/selenium/environment:appserver_deploy.jar",
+        "//javascript/atoms",
+        "//third_party/closure/goog",
+        "//third_party/js/selenium:webdriver_json",
     ],
     args = [
         "--workers=1",
@@ -52,26 +56,27 @@ config_setting(
         "//conditions:default": [ "netcoreapp2.1" ],
     }),
     deps = select({
-        ":netframework":
-            [
-                "//dotnet/src/webdriver:net47",
-                "@json.net//:Newtonsoft.Json",
-                "@benderproxy//:BenderProxy",
-                "@moq//:Moq",
-            ],
-        ":netcore":
-            [
-                "//dotnet/src/webdriver:netstandard2.0assembly",
-                "@json.net//:Newtonsoft.Json",
-                "@benderproxy//:BenderProxy",
-                "@moq//:Moq",
-            ],
-        "//conditions:default":
-            [
-                "//dotnet/src/webdriver:netstandard2.0assembly",
-                "@json.net//:Newtonsoft.Json",
-                "@benderproxy//:BenderProxy",
-                "@moq//:Moq",
-            ],
+        ":netframework": [
+            "//dotnet/src/webdriver:net47assembly",
+            "@json.net//:Newtonsoft.Json",
+            "@benderproxy//:BenderProxy",
+            "@moq//:Moq",
+        ],
+        ":netcore": [
+            "//dotnet/src/webdriver:netstandard2.0assembly",
+            "@json.net//:Newtonsoft.Json",
+            "@benderproxy//:BenderProxy",
+            "@moq//:Moq",
+        ],
+        "//conditions:default": [
+            "//dotnet/src/webdriver:netstandard2.0assembly",
+            "@json.net//:Newtonsoft.Json",
+            "@benderproxy//:BenderProxy",
+            "@moq//:Moq",
+        ],
+    }),
+    is_windows = select({
+        "@bazel_tools//src/conditions:host_windows": True,
+        "//conditions:default": False,
     }),
 ) for (target_name, config_setting) in SUPPORTED_BROWSERS]
diff --git a/java/client/test/org/openqa/selenium/environment/BUILD.bazel b/java/client/test/org/openqa/selenium/environment/BUILD.bazel
@@ -1,6 +1,16 @@
 load("@rules_jvm_external//:defs.bzl", "artifact")
 load("//java:defs.bzl", "java_test_suite")
 
+filegroup(
+    name = "keystore",
+    srcs = [
+        "webserver/keystore",
+    ],
+    visibility = [
+        "//dotnet/test:__subpackages__",
+    ],
+)
+
 java_library(
     name = "environment",
     srcs = glob(

diff --git a/javascript/atoms/BUILD.bazel b/javascript/atoms/BUILD.bazel
@@ -13,6 +13,7 @@ filegroup(
         "**/*.svg",
     ]),
     visibility = [
+        "//dotnet/test:__subpackages__",
         "//java/client/test/org/openqa/selenium/environment:__pkg__",
         "//javascript/node/selenium-webdriver:__pkg__",
     ],

diff --git a/third_party/closure/goog/BUILD.bazel b/third_party/closure/goog/BUILD.bazel
@@ -6,6 +6,7 @@ filegroup(
         "**/*.js",
     ]),
     visibility = [
+        "//dotnet/test:__subpackages__",
         "//java/client/test/org/openqa/selenium/environment:__pkg__",
     ],
 )
diff --git a/third_party/js/selenium/BUILD.bazel b/third_party/js/selenium/BUILD.bazel
@@ -18,6 +18,7 @@ copy_file(
     out = "webdriver_prefs.json",
     visibility = [
         "//dotnet/src/webdriver:__pkg__",
+        "//dotnet/test:__subpackages__",
         "//java/client/src/org/openqa/selenium/firefox:__pkg__",
         "//java/client/test/org/openqa/selenium/environment:__pkg__",
         "//py:__pkg__",