Allow .NET CDP code generator to run silently

rafaelfranca · Nov 12, 2020 · cc70098 · cc70098
1 parent cc5cf1b
commit cc70098
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 5 deletions.
diff --git a/dotnet/private/generate_devtools.bzl b/dotnet/private/generate_devtools.bzl
@@ -6,6 +6,7 @@ def _generate_devtools_impl(ctx):
     args.add_all("-b", [ctx.attr.browser_protocol.files.to_list()[0]])
     args.add_all("-j", [ctx.attr.js_protocol.files.to_list()[0]])
     args.add_all("-t", [ctx.attr.template.files.to_list()[0]])
+    args.add("-q")
     args.add_all("-o", [outdir.path])
 
     ctx.actions.run(

diff --git a/third_party/dotnet/devtools/src/generator/CommandLineOptions.cs b/third_party/dotnet/devtools/src/generator/CommandLineOptions.cs
@@ -18,6 +18,13 @@ public CommandLineOptions()
             HelpText = "Forces the Chrome Protocol Definition to be downloaded from source even if it already exists.")]
         public bool ForceDownload { get; set; }
 
+        [Option(
+            'q',
+            "quiet",
+            Default = false,
+            HelpText = "Suppresses console output.")]
+        public bool Quiet { get; set; }
+
         [Option(
             "force",
             Default = false,

diff --git a/third_party/dotnet/devtools/src/generator/Program.cs b/third_party/dotnet/devtools/src/generator/Program.cs
@@ -41,21 +41,37 @@ static int Main(string[] args)
                 .BuildServiceProvider();
 
             //Get the protocol Data.
-            Console.WriteLine("Loading protocol definition...");
+            if (!cliArguments.Quiet)
+            {
+                Console.WriteLine("Loading protocol definition...");
+            }
+
             var protocolDefinitionData = GetProtocolDefinitionData(cliArguments);
 
             var protocolDefinition = protocolDefinitionData.ToObject<ProtocolDefinition.ProtocolDefinition>(new JsonSerializer() { MetadataPropertyHandling = MetadataPropertyHandling.Ignore });
 
             //Begin the code generation process.
-            Console.WriteLine("Generating protocol definition code files...");
+            if (!cliArguments.Quiet)
+            {
+                Console.WriteLine("Generating protocol definition code files...");
+            }
+
             var protocolGenerator = serviceProvider.GetRequiredService<ICodeGenerator<ProtocolDefinition.ProtocolDefinition>>();
             var codeFiles = protocolGenerator.GenerateCode(protocolDefinition, null);
 
             //Delete the output folder if force is specified and it exists...
-            Console.WriteLine("Writing generated code files to {0}...", cliArguments.OutputPath);
+            if (!cliArguments.Quiet)
+            {
+                Console.WriteLine("Writing generated code files to {0}...", cliArguments.OutputPath);
+            }
+
             if (Directory.Exists(cliArguments.OutputPath) && cliArguments.ForceOverwrite)
             {
-                Console.WriteLine("Generating protocol definition project...");
+                if (!cliArguments.Quiet)
+                {
+                    Console.WriteLine("Generating protocol definition project...");
+                }
+
                 Directory.Delete(cliArguments.OutputPath, true);
             }
 
@@ -84,7 +100,11 @@ static int Main(string[] args)
             }
 
             //Completed.
-            Console.WriteLine("All done!");
+            if (!cliArguments.Quiet)
+            {
+                Console.WriteLine("All done!");
+            }
+
             return 0;
         }