Prevent widget from modifying data outside the list.

rafaelsetragni · May 27, 2022 · 609212c · 609212c
1 parent 71f7c3a
commit 609212c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/grouped_list.dart b/lib/grouped_list.dart
@@ -380,7 +380,7 @@ class _GroupedListViewState<T, E> extends State<GroupedListView<T, E>> {
   }
 
   List<T> _sortElements() {
-    var elements = widget.elements;
+    var elements = [...widget.elements];
     if (widget.sort && elements.isNotEmpty) {
       elements.sort((e1, e2) {
         int? compareResult;
@@ -411,7 +411,7 @@ class _GroupedListViewState<T, E> extends State<GroupedListView<T, E>> {
 
   Widget _showFixedGroupHeader(int topElementIndex) {
     _groupHeaderKey = GlobalKey();
-    if (widget.useStickyGroupSeparators && widget.elements.isNotEmpty) {
+    if (widget.useStickyGroupSeparators && _sortedElements.isNotEmpty) {
       T topElement;
 
       try {

diff --git a/lib/sliver_grouped_list.dart b/lib/sliver_grouped_list.dart
@@ -130,7 +130,7 @@ class _SliverGroupedListViewState<T, E>
   }
 
   List<T> _sortElements() {
-    var elements = widget.elements;
+    var elements = [...widget.elements];
     if (widget.sort && elements.isNotEmpty) {
       elements.sort((e1, e2) {
         int? compareResult;

diff --git a/test/grouped_list_test.dart b/test/grouped_list_test.dart
@@ -52,6 +52,7 @@ void main() {
     expect(find.text('John'), findsNothing);
     expect(find.text('Danny'), findsOneWidget);
   });
+
   testWidgets('finds elemets and group separators with reverse list',
       (WidgetTester tester) async {
     await tester.pumpWidget(_buildApp(_elements, reverse: true));
@@ -73,6 +74,7 @@ void main() {
   testWidgets('empty list', (WidgetTester tester) async {
     await tester.pumpWidget(_buildApp([]));
   });
+
   testWidgets('empty reversed list', (WidgetTester tester) async {
     await tester.pumpWidget(_buildApp([], reverse: true));
   });