Skip to content

Commit

Permalink
Copy only one libmkldnn file (apache#10245)
Browse files Browse the repository at this point in the history
* Only copy libmkldnn.so

* Update Jenkins.

* use libmkldnn.so.0

* copy the right libmklml file.
  • Loading branch information
zheng-da authored and szha committed Mar 27, 2018
1 parent e08e1fd commit 13bd603
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ mx_lib = 'lib/libmxnet.so, lib/libmxnet.a, 3rdparty/dmlc-core/libdmlc.a, 3rdpart
// mxnet cmake libraries, in cmake builds we do not produce a libnvvm static library by default.
mx_cmake_lib = 'build/libmxnet.so, build/libmxnet.a, build/3rdparty/dmlc-core/libdmlc.a, build/tests/mxnet_unit_tests, build/3rdparty/openmp/runtime/src/libomp.so'
mx_cmake_mkldnn_lib = 'build/libmxnet.so, build/libmxnet.a, build/3rdparty/dmlc-core/libdmlc.a, build/tests/mxnet_unit_tests, build/3rdparty/openmp/runtime/src/libomp.so, build/3rdparty/mkldnn/src/libmkldnn.so, build/3rdparty/mkldnn/src/libmkldnn.so.0'
mx_mkldnn_lib = 'lib/libmxnet.so, lib/libmxnet.a, lib/libiomp5.so, lib/libmklml_gnu.so, lib/libmkldnn.so, lib/libmkldnn.so.0, lib/libmklml_intel.so, 3rdparty/dmlc-core/libdmlc.a, 3rdparty/nnvm/lib/libnnvm.a'
mx_mkldnn_lib = 'lib/libmxnet.so, lib/libmxnet.a, lib/libiomp5.so, lib/libmkldnn.so.0, lib/libmklml_intel.so, 3rdparty/dmlc-core/libdmlc.a, 3rdparty/nnvm/lib/libnnvm.a'
// command to start a docker container
docker_run = 'tests/ci_build/ci_build.sh'
// timeout in minutes
Expand Down
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -432,9 +432,9 @@ lib/libmxnet.so: $(ALLX_DEP)
-Wl,${WHOLE_ARCH} $(filter %libnnvm.a, $^) -Wl,${NO_WHOLE_ARCH}
ifeq ($(USE_MKLDNN), 1)
ifeq ($(UNAME_S), Darwin)
install_name_tool -change '@rpath/libmklml.dylib' '@loader_path/libmklml.dylib' lib/libmxnet.so
install_name_tool -change '@rpath/libiomp5.dylib' '@loader_path/libiomp5.dylib' lib/libmxnet.so
install_name_tool -change '@rpath/libmkldnn.0.dylib' '@loader_path/libmkldnn.0.dylib' lib/libmxnet.so
install_name_tool -change '@rpath/libmklml.dylib' '@loader_path/libmklml.dylib' $@
install_name_tool -change '@rpath/libiomp5.dylib' '@loader_path/libiomp5.dylib' $@
install_name_tool -change '@rpath/libmkldnn.0.dylib' '@loader_path/libmkldnn.0.dylib' $@
endif
endif

Expand Down
12 changes: 9 additions & 3 deletions prepare_mkldnn.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,13 @@ if [ ! -z "$HOME_MKLDNN" ]; then
fi

if [ $OSTYPE == "darwin16" ]; then
MKLDNN_LIBFILE="$MKLDNN_INSTALLDIR/lib/libmkldnn.dylib"
OMP_LIBFILE="$MKLDNN_INSTALLDIR/lib/libiomp5.dylib"
MKLML_LIBFILE="$MKLDNN_INSTALLDIR/lib/libmklml.dylib"
MKLDNN_LIBFILE="$MKLDNN_INSTALLDIR/lib/libmkldnn.0.dylib"
else
MKLDNN_LIBFILE="$MKLDNN_INSTALLDIR/lib/libmkldnn.so"
OMP_LIBFILE="$MKLDNN_INSTALLDIR/lib/libiomp5.so"
MKLML_LIBFILE="$MKLDNN_INSTALLDIR/lib/libmklml_intel.so"
MKLDNN_LIBFILE="$MKLDNN_INSTALLDIR/lib/libmkldnn.so.0"
fi

if [ -z $MKLDNNROOT ]; then
Expand Down Expand Up @@ -103,7 +107,9 @@ if [ ! -f $MKLDNN_LIBFILE ]; then
make -C $MKLDNN_BUILDDIR install >&2
rm -rf $MKLDNN_BUILDDIR
mkdir -p $MKLDNN_LIBDIR
cp $MKLDNN_INSTALLDIR/lib/* $MKLDNN_LIBDIR
cp $OMP_LIBFILE $MKLDNN_LIBDIR
cp $MKLML_LIBFILE $MKLDNN_LIBDIR
cp $MKLDNN_LIBFILE $MKLDNN_LIBDIR
fi
MKLDNNROOT=$MKLDNN_INSTALLDIR
fi
Expand Down

0 comments on commit 13bd603

Please sign in to comment.