-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --with-summary option #16
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 97.54% 97.59% +0.04%
==========================================
Files 1 1
Lines 163 166 +3
==========================================
+ Hits 159 162 +3
Misses 4 4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 97.54% 96.98% -0.56%
==========================================
Files 1 1
Lines 163 166 +3
==========================================
+ Hits 159 161 +2
- Misses 4 5 +1
Continue to review full report at Codecov.
|
piplicenses.py
Outdated
@@ -310,6 +316,10 @@ def create_parser(): | |||
action='store_true', | |||
default=False, | |||
help='dump with package urls') | |||
parser.add_argument('-d', '--with-summary', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dtatarkin Thanks for your patch. I want to merge because it looks good.
How about replacing the command line option with --with-description
instead of --with-summary
? It seems to be consistent with the short option -d
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right --with-description
is more intuitive, I will rename it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!! Thank you to add the perfect change and test. I will soon register the next release with PyPI.
This option was very helpful to me. Hope this helps someone else.