Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --with-summary option #16

Merged
merged 3 commits into from
Dec 23, 2018
Merged

Add --with-summary option #16

merged 3 commits into from
Dec 23, 2018

Conversation

dtatarkin
Copy link
Contributor

This option was very helpful to me. Hope this helps someone else.

@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #16 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   97.54%   97.59%   +0.04%     
==========================================
  Files           1        1              
  Lines         163      166       +3     
==========================================
+ Hits          159      162       +3     
  Misses          4        4
Impacted Files Coverage Δ
piplicenses.py 97.59% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9eaa6...2b417bc. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #16 into master will decrease coverage by 0.55%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   97.54%   96.98%   -0.56%     
==========================================
  Files           1        1              
  Lines         163      166       +3     
==========================================
+ Hits          159      161       +2     
- Misses          4        5       +1
Impacted Files Coverage Δ
piplicenses.py 96.98% <66.66%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9eaa6...41e388f. Read the comment docs.

piplicenses.py Outdated
@@ -310,6 +316,10 @@ def create_parser():
action='store_true',
default=False,
help='dump with package urls')
parser.add_argument('-d', '--with-summary',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dtatarkin Thanks for your patch. I want to merge because it looks good.

How about replacing the command line option with --with-description instead of --with-summary? It seems to be consistent with the short option -d.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right --with-description is more intuitive, I will rename it

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!! Thank you to add the perfect change and test. I will soon register the next release with PyPI.

@raimon49 raimon49 merged commit 37100f4 into raimon49:master Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants