test: update tests for resizable button

Signed-off-by: tygao <tygao@amazon.com>

src/core/public/overlays/sidecar/components/resizable_button.test.tsx

@@ -44,7 +44,7 @@ test('it should be vertical when docked mode is takeover', () => {
   expect(component).toMatchSnapshot();
 });
 
-test('it should emit onResize with new flyout size when drag and horizontal', () => {
+test('it should emit onResize with new flyout size when docked right and drag and horizontal', () => {
   const windowEvents = storeWindowEvents();
 
   const onResize = jest.fn();
@@ -60,6 +60,22 @@ test('it should emit onResize with new flyout size when drag and horizontal', ()
   expect(component).toMatchSnapshot();
 });
 
+test('it should emit onResize with new flyout size when docked left and drag and horizontal', () => {
+  const windowEvents = storeWindowEvents();
+
+  const onResize = jest.fn();
+  const newProps = { ...props, onResize, dockedMode: SIDECAR_DOCKED_MODE.LEFT };
+  const component = shallow(<ResizableButton {...newProps} />);
+  const resizer = component.find(`[data-test-subj~="resizableButton"]`).first();
+  expect(onResize).not.toHaveBeenCalled();
+  resizer.simulate('mousedown', { clientX: 0, pageX: 0, pageY: 0 });
+  windowEvents?.mousemove({ clientX: 1000, pageX: 0, pageY: 0 });
+  windowEvents?.mouseup();
+  const newSize = 1000 + DEFAULT_FLYOUT_SIZE;
+  expect(onResize).toHaveBeenCalledWith(newSize);
+  expect(component).toMatchSnapshot();
+});
+
 test('it should emit onResize with new flyout size when drag and vertical', () => {
   const windowEvents = storeWindowEvents();
 

src/core/public/overlays/sidecar/sidecar_service.test.tsx

@@ -53,6 +53,16 @@ describe('SidecarService', () => {
       const content = mount(mockReactDomRender.mock.calls[0][0]);
       expect(content.html()).toMatchSnapshot();
     });
+
+    it('does not unmount if targetDom is null', async () => {
+      const sidecarRef = new SidecarService().start({ i18n: i18nMock, targetDomElement: null });
+      const ref = sidecarRef.open(mountText('Sidecar content'), options);
+      const content = mount(mockReactDomRender.mock.calls[0][0]);
+      expect(content.html()).toMatchSnapshot();
+      await ref.close();
+      expect(mockReactDomUnmount).not.toHaveBeenCalled();
+    });
+
     describe('with a currently active sidecar', () => {
       let ref1: OverlayRef;
       beforeEach(() => {

src/core/public/overlays/sidecar/sidecar_service.tsx

@@ -102,7 +102,7 @@ export interface OverlaySidecarOpenOptions {
 
 interface StartDeps {
   i18n: I18nStart;
-  targetDomElement: Element;
+  targetDomElement: Element | null;
 }
 
 export enum SIDECAR_DOCKED_MODE {