Skip to content

Commit

Permalink
test-bot: fix coverage on Travis CI
Browse files Browse the repository at this point in the history
Make sure to call `brew tests` only once with `--coverage` to avoid
expensive multiple runs and to prevent later runs from overwriting
previously sent results to Coveralls. (The previous setup overwrote the
results from a regular run with results from the `--generic` run.)

The `--no-compat` variant without any other options specified seemed to
be the most appropriate for a coverage report.

Closes Homebrew#546.

Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
  • Loading branch information
UniqMartin committed Jul 19, 2016
1 parent 9cf508c commit 5768e32
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Library/Homebrew/dev-cmd/test-bot.rb
Original file line number Diff line number Diff line change
Expand Up @@ -659,14 +659,15 @@ def homebrew

if @tap.nil?
tests_args = []
tests_args_coverage = []
if RUBY_TWO
tests_args << "--official-cmd-taps"
tests_args << "--coverage" if ENV["TRAVIS"]
tests_args_coverage << "--coverage" if ENV["TRAVIS"]
end
test "brew", "tests", *tests_args
test "brew", "tests", "--generic", "--only=integration_cmds",
*tests_args
test "brew", "tests", "--no-compat"
test "brew", "tests", "--no-compat", *tests_args_coverage
test "brew", "readall", "--syntax"
# test update from origin/master to current commit.
test "brew", "update-test"
Expand Down

0 comments on commit 5768e32

Please sign in to comment.