MDL-56677 cohort: Fix cohort search box misalignment

ralferlebach · Nov 3, 2016 · 18bb288 · 18bb288
1 parent 5d0299e
commit 18bb288
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/cohort/index.php b/cohort/index.php
@@ -103,7 +103,7 @@
 }
 
 // Add search form.
-$search  = html_writer::start_tag('form', array('id'=>'searchcohortquery', 'method'=>'get', 'class' => 'form-inline'));
+$search  = html_writer::start_tag('form', array('id'=>'searchcohortquery', 'method'=>'get', 'class' => 'form-inline search-cohort'));
 $search .= html_writer::start_div('m-b-1');
 $search .= html_writer::label(get_string('searchcohort', 'cohort'), 'cohort_search_q', true,
         array('class' => 'm-r-1')); // No : in form labels!

diff --git a/theme/bootstrapbase/less/moodle/buttons.less b/theme/bootstrapbase/less/moodle/buttons.less
@@ -78,6 +78,25 @@ input[type="reset"] {
     .btn-lineup;
 }
 
+// The above buttons rules are really dumb and muck things up for simple pages using bootstrap correctly.
+// e.g. cohort search form.
+// Undo the above silly rules one by one for pages we know to be broken by them.
+form.search-cohort input[type="text"],
+form.search-cohort input[type="submit"],
+form.search-cohort label {
+    .m-t-1
+}
+
+form.search-cohort label {
+    margin-bottom: 0;
+    vertical-align: middle;
+}
+
+form.search-cohort input[type="submit"] {
+    margin-bottom: 0;
+    margin-left: 0;
+}
+
 button {
     &.yui3-button {
         &.closebutton {

diff --git a/theme/bootstrapbase/style/moodle.css b/theme/bootstrapbase/style/moodle.css
@@ -15818,6 +15818,20 @@ input[type="submit"],
 input[type="reset"] {
   margin: 0 0 10px 5px;
 }
+form.search-cohort input[type="text"],
+form.search-cohort input[type="submit"],
+form.search-cohort label {
+  margin-top: 14px !important;
+  /* stylelint-disable-line declaration-no-important */
+}
+form.search-cohort label {
+  margin-bottom: 0;
+  vertical-align: middle;
+}
+form.search-cohort input[type="submit"] {
+  margin-bottom: 0;
+  margin-left: 0;
+}
 button.yui3-button.closebutton {
   background-position: 0 0;
 }