MDL-51983 actionmenu: fix hideIfOutside

The hideIfOutside function was being too restrictive with the selector for checking if the event occurred within a menu child (anchor tag) rather than the menu itself.
ralferlebach · Nov 4, 2015 · 5d2c5ba · 5d2c5ba
1 parent 4456c30
commit 5d2c5ba
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/lib/yui/build/moodle-core-actionmenu/moodle-core-actionmenu-debug.js b/lib/yui/build/moodle-core-actionmenu/moodle-core-actionmenu-debug.js
@@ -421,7 +421,7 @@ ACTIONMENU.prototype = {
      * @param {EventFacade} e
      */
     hideIfOutside : function(e) {
-        if (!e.target.ancestor(SELECTOR.MENUCHILD, true)) {
+        if (!e.target.ancestor(SELECTOR.MENUCONTENT, true)) {
             this.hideMenu(e);
         }
     },

diff --git a/lib/yui/build/moodle-core-actionmenu/moodle-core-actionmenu-min.js b/lib/yui/build/moodle-core-actionmenu/moodle-core-actionmenu-min.js
diff --git a/lib/yui/build/moodle-core-actionmenu/moodle-core-actionmenu.js b/lib/yui/build/moodle-core-actionmenu/moodle-core-actionmenu.js
@@ -418,7 +418,7 @@ ACTIONMENU.prototype = {
      * @param {EventFacade} e
      */
     hideIfOutside : function(e) {
-        if (!e.target.ancestor(SELECTOR.MENUCHILD, true)) {
+        if (!e.target.ancestor(SELECTOR.MENUCONTENT, true)) {
             this.hideMenu(e);
         }
     },

diff --git a/lib/yui/src/actionmenu/js/actionmenu.js b/lib/yui/src/actionmenu/js/actionmenu.js
@@ -419,7 +419,7 @@ ACTIONMENU.prototype = {
      * @param {EventFacade} e
      */
     hideIfOutside : function(e) {
-        if (!e.target.ancestor(SELECTOR.MENUCHILD, true)) {
+        if (!e.target.ancestor(SELECTOR.MENUCONTENT, true)) {
             this.hideMenu(e);
         }
     },