forked from elkowar/eww
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when icon not found in either theme directory #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get the following error when i try to check it out.
MAybe i have a wrong order of operations ? This is what i did.
|
@NicTanghe You're on the wrong repo, this is ralismark/eww not elkowar/eww
|
I've now cherry-picked most of the contents of this PR (which now has a bunch of my commits because I rebased... oops). Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crashing with some applications which only provide icons in
/usr/share/icons
. Tested withqbittorrent
andkeepassxc
which crash the current version.Also doesn't crash on applications which only provide the icon as a pixmap (tested with
discord
) - it will now show the default "icon not found" pixmap instead.Unrelated but leaving a note here:
qbittorrent
might show two entries but this is actually because it does spawn two notifier items, so some extra filtering might be required for some applications.EDIT: Added pixmap loading from DBus. There is some code duplication since I didn't want to remove existing code as of right now.