Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when icon not found in either theme directory #2

Closed
wants to merge 16 commits into from

Conversation

Onyx47
Copy link

@Onyx47 Onyx47 commented May 5, 2023

Fixes crashing with some applications which only provide icons in /usr/share/icons. Tested with qbittorrent and keepassxc which crash the current version.

Also doesn't crash on applications which only provide the icon as a pixmap (tested with discord) - it will now show the default "icon not found" pixmap instead.

Unrelated but leaving a note here: qbittorrent might show two entries but this is actually because it does spawn two notifier items, so some extra filtering might be required for some applications.

EDIT: Added pixmap loading from DBus. There is some code duplication since I didn't want to remove existing code as of right now.

@Onyx47 Onyx47 mentioned this pull request May 5, 2023
11 tasks
@NicTanghe
Copy link

I get the following error when i try to check it out.

❯ gh pr checkout 2
fatal: couldn't find remote ref refs/heads/add-example-config

MAybe i have a wrong order of operations ?

This is what i did.

❯ gh pr checkout 743
remote: Enumerating objects: 131, done.
remote: Counting objects: 100% (131/131), done.
remote: Compressing objects: 100% (55/55), done.
remote: Total 131 (delta 76), reused 113 (delta 76), pack-reused 0
Receiving objects: 100% (131/131), 55.86 KiB | 3.72 MiB/s, done.
Resolving deltas: 100% (76/76), completed with 6 local objects.
From https://github.com/elkowar/eww
 * [new ref]         refs/pull/743/head -> tray-3
Switched to branch 'tray-3'

eww on  tray-3 via  via 🦀 v1.70.0
❯ gh pr checkout 2
fatal: couldn't find remote ref refs/heads/add-example-config

@eclairevoyant
Copy link

eclairevoyant commented Jun 10, 2023

@NicTanghe You're on the wrong repo, this is ralismark/eww not elkowar/eww

gh pr checkout 2 on your local clone will checkout elkowar#2, not this PR.

@ralismark
Copy link
Owner

I've now cherry-picked most of the contents of this PR (which now has a bunch of my commits because I rebased... oops). Thanks for this!

@ralismark ralismark closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants