Removing async_trait and refactoring #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a bit but now its done. One of the bigger commits which removes the future crate (replaced wit std::future::Future; both are interchangeable and thus should not result in changes when calling the api) and the async_trait.
Also combined a few modules to make reqwest look more like curl and moved the stuff from async_internals to the other functions in lib.rs.
(Btw I'm now the the second highest contributor when it comes to deletions. I'm not sure whether that is a good thing 😆)
Edit: Forget to mention #80